Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Bump k8s and docker client library deps #5038

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Nov 18, 2020

Major dep updates:

  • Kubernetes client libraries bumped from 0.18.1 to 0.19.3 (k8s.io/apimachinery was already 0.19.2)
  • Docker client library changed from v1.14.0 to v20.10.0-beta1
  • go-containerregistry updated from v0.1.1 to v0.1.4

Required code updates:

  • All calls to various k8s client libraries consume a context now, so this was plumbed through in many places

NOTE: This change is currently incorporating changes from a personal fork of buildpacks/pack, as there were unresolvable dependency incompatibilities. This PR should not be merged until buildpacks/pack#960 is upstreamed, and the dependency replacement is removed.

This change is non-functional.

@nkubala nkubala requested a review from a team as a code owner November 18, 2020 23:02
@nkubala nkubala requested a review from ilya-zuyev November 18, 2020 23:02
@google-cla google-cla bot added the cla: yes label Nov 18, 2020
@nkubala nkubala changed the title [deps] Bump k8s and docker client library deps [WIP] [deps] Bump k8s and docker client library deps Nov 19, 2020
@nkubala nkubala force-pushed the big-deps branch 2 times, most recently from db4e873 to 6af72a0 Compare November 19, 2020 19:57
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #5038 (2562e93) into master (e91c8e6) will not change coverage.
The diff coverage is 48.78%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5038   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files         368      368           
  Lines       12971    12971           
=======================================
  Hits         9396     9396           
  Misses       2886     2886           
  Partials      689      689           
Impacted Files Coverage Δ
pkg/diag/validator/pod.go 1.22% <0.00%> (ø)
pkg/skaffold/build/cluster/cluster.go 25.80% <0.00%> (ø)
pkg/skaffold/build/cluster/kaniko.go 22.36% <0.00%> (ø)
pkg/skaffold/build/cluster/logs.go 15.78% <0.00%> (ø)
pkg/skaffold/deploy/helm/deploy.go 70.50% <0.00%> (ø)
pkg/webhook/kubernetes/deployment.go 0.00% <0.00%> (ø)
pkg/webhook/kubernetes/service.go 0.00% <0.00%> (ø)
pkg/skaffold/build/cluster/secret.go 40.32% <28.57%> (ø)
pkg/skaffold/deploy/label/labels.go 45.58% <33.33%> (ø)
pkg/skaffold/kubernetes/wait.go 45.31% <33.33%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91c8e6...2562e93. Read the comment docs.

@nkubala nkubala changed the title [WIP] [deps] Bump k8s and docker client library deps [deps] Bump k8s and docker client library deps Nov 30, 2020
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a whole lotta context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants