Fix suggested "gpg" usage to stop relying on deprecated and insecure behavior #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Wanna fix it properly here at the source before replicating outwards.) |
| @@ -122,7 +122,7 @@ RUN set -x \ | |||
| && curl -fSL "https://github.com/krallin/tini/releases/download/$TINI_VERSION/tini.asc" -o /usr/local/bin/tini.asc \ | |||
| && export GNUPGHOME="$(mktemp -d)" \ | |||
There was a problem hiding this comment.
If this GNUPGHOME export is a best practice, it seems like it should be in the python.tar.xz.asc example below as well.
There was a problem hiding this comment.
Yeah, that's a good point -- I was going to update that separately, but might as well include it here too.
|
LGTM |
tianon
added a commit
that referenced
this pull request
Feb 8, 2016
Fix suggested "gpg" usage to stop relying on deprecated and insecure behavior
|
I just realized we probably ought to link to the source of where this is pointed out to be "insecure"... 😇 From
|
This was referenced Feb 27, 2016
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 29, 2016
Merged
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Mar 1, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference). - `drupal`: use PHP 7 for 8+ (docker-library/drupal#35) - `ghost`: copy all themes explicitly (docker-library/ghost#31) - `java`: 9~b107-1 - `rails`: 4.2.5.2 - `rocket.chat`: 0.20.0 - `ruby`: remove 2.0 (EOL; docker-library/ruby#71)
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Mar 2, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference). - `drupal`: use PHP 7 for 8+ (docker-library/drupal#35) - `ghost`: copy all themes explicitly (docker-library/ghost#31) - `java`: 9~b107-1 - `rails`: 4.2.5.2 - `rocket.chat`: 0.20.0 - `ruby`: remove 2.0 (EOL; docker-library/ruby#71) - `django`: 1.9.3 - `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83) - `redmine`: passenger 5.0.26
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Mar 2, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference). - `drupal`: use PHP 7 for 8+ (docker-library/drupal#35) - `ghost`: copy all themes explicitly (docker-library/ghost#31) - `java`: 9~b107-1 - `rails`: 4.2.5.2 - `rocket.chat`: 0.20.0 - `ruby`: remove 2.0 (EOL; docker-library/ruby#71) - `django`: 1.9.3 - `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83) - `rabbitmq`: 3.6.1 - `redmine`: passenger 5.0.26
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Mar 2, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference). - `drupal`: use PHP 7 for 8+ (docker-library/drupal#35) - `ghost`: copy all themes explicitly (docker-library/ghost#31) - `rails`: 4.2.5.2 - `rocket.chat`: 0.20.0 - `ruby`: remove 2.0 (EOL; docker-library/ruby#71) - `django`: 1.9.3 - `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83) - `rabbitmq`: 3.6.1 - `redmine`: passenger 5.0.26
tianon
added a commit
to tianon/docker-piwik
that referenced
this pull request
Mar 4, 2016
1. update GPG usage ala docker-library/official-images#1420 2. simplify "GeoIP" download and ensure download failure will be obvious (eases debugging) 3. move the `VOLUME` definition down to avoid creating additional volumes during build (adding a comment for additional clarity) 4. adjust the entrypoint to consistently assume `/var/www/html` is the current directory (instead of only assuming so for the `tar` line)
This was referenced Mar 4, 2016
This was referenced Mar 30, 2016
Merged
makuk66
added a commit
to docker-solr/docker-solr
that referenced
this pull request
Apr 27, 2016
9 tasks
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference). - `drupal`: use PHP 7 for 8+ (docker-library/drupal#35) - `ghost`: copy all themes explicitly (docker-library/ghost#31) - `rails`: 4.2.5.2 - `rocket.chat`: 0.20.0 - `ruby`: remove 2.0 (EOL; docker-library/ruby#71) - `django`: 1.9.3 - `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83) - `rabbitmq`: 3.6.1 - `redmine`: passenger 5.0.26
This was referenced Jul 19, 2016
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @aburch -- does this look at least more correct? 😇 (anything we could do to make this pattern even better?)