Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP 7 for Drupal 8 going forward #35

Merged
merged 1 commit into from
Feb 27, 2016

Conversation

skyred
Copy link
Contributor

@skyred skyred commented Feb 24, 2016

Here is why: http://fabianx.drupalgardens.com/blog/why-drupal-8-defaulting-its-testing-php7-and-why-you-should-too

And the current status of PHP 7 Support in D8:

Drupal 8 currently has 100% pass on PHP 7
https://www.drupal.org/node/2454439

@tianon
Copy link
Member

tianon commented Feb 24, 2016

Is it just an oversight that https://www.drupal.org/requirements/php#drupalversions isn't updated? 😞

Also, what implications does this have for plugins / 3rd party code? Is the ecosystem relatively on-board with this, or is it still straggling?

@skyred
Copy link
Contributor Author

skyred commented Feb 24, 2016

@tianon The linked documentation hasn't been updated yet, because there are three additional things (2 out of 3 are related to D8) to add, which are listed on the https://www.drupal.org/node/2455455. However, the current code base has 100% pass on PHP 7.

So, I hope that we can upgrade this official image, and it will be useful for sand-boxing and getting more people to test D8 on PHP 7.

@skyred
Copy link
Contributor Author

skyred commented Feb 26, 2016

@tianon The issue has been fixed. Also, I have worked with other Drupal Community member to update your linked documentation. D8 is supported. Can you please review this PR?

@yosifkit
Copy link
Member

LGTM

@tianon
Copy link
Member

tianon commented Feb 27, 2016

@skyred dang, nice work! 😄 👍

Can't argue with that! LGTM

tianon added a commit that referenced this pull request Feb 27, 2016
Use PHP 7 for Drupal 8 going forward
@tianon tianon merged commit bbf0fdc into docker-library:master Feb 27, 2016
tianon added a commit to infosiftr/stackbrew that referenced this pull request Mar 1, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference).

- `drupal`: use PHP 7 for 8+ (docker-library/drupal#35)
- `ghost`: copy all themes explicitly (docker-library/ghost#31)
- `java`: 9~b107-1
- `rails`: 4.2.5.2
- `rocket.chat`: 0.20.0
- `ruby`: remove 2.0 (EOL; docker-library/ruby#71)
tianon added a commit to infosiftr/stackbrew that referenced this pull request Mar 2, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference).

- `drupal`: use PHP 7 for 8+ (docker-library/drupal#35)
- `ghost`: copy all themes explicitly (docker-library/ghost#31)
- `java`: 9~b107-1
- `rails`: 4.2.5.2
- `rocket.chat`: 0.20.0
- `ruby`: remove 2.0 (EOL; docker-library/ruby#71)

- `django`: 1.9.3
- `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83)
- `redmine`: passenger 5.0.26
tianon added a commit to infosiftr/stackbrew that referenced this pull request Mar 2, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference).

- `drupal`: use PHP 7 for 8+ (docker-library/drupal#35)
- `ghost`: copy all themes explicitly (docker-library/ghost#31)
- `java`: 9~b107-1
- `rails`: 4.2.5.2
- `rocket.chat`: 0.20.0
- `ruby`: remove 2.0 (EOL; docker-library/ruby#71)

- `django`: 1.9.3
- `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83)
- `rabbitmq`: 3.6.1
- `redmine`: passenger 5.0.26
tianon added a commit to infosiftr/stackbrew that referenced this pull request Mar 2, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference).

- `drupal`: use PHP 7 for 8+ (docker-library/drupal#35)
- `ghost`: copy all themes explicitly (docker-library/ghost#31)
- `rails`: 4.2.5.2
- `rocket.chat`: 0.20.0
- `ruby`: remove 2.0 (EOL; docker-library/ruby#71)

- `django`: 1.9.3
- `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83)
- `rabbitmq`: 3.6.1
- `redmine`: passenger 5.0.26
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Unless otherwise specified, these are just updates due to docker-library#1420 (reference).

- `drupal`: use PHP 7 for 8+ (docker-library/drupal#35)
- `ghost`: copy all themes explicitly (docker-library/ghost#31)
- `rails`: 4.2.5.2
- `rocket.chat`: 0.20.0
- `ruby`: remove 2.0 (EOL; docker-library/ruby#71)

- `django`: 1.9.3
- `elasticsearch`: add `WORKDIR` (docker-library/elasticsearch#83)
- `rabbitmq`: 3.6.1
- `redmine`: passenger 5.0.26
@skyred skyred deleted the patch-12 branch April 6, 2017 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants