Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback when card is missing #439

Merged
merged 7 commits into from
May 13, 2024
Merged

Add feedback when card is missing #439

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1af68fc
Remove some useless css rules
thomashbrnrd May 7, 2024
81633ef
Add feedback when card is missing
thomashbrnrd May 7, 2024
3788651
Update missing card alert from warning to error
thomashbrnrd May 13, 2024
f7515a3
Update disclaimers
thomashbrnrd May 13, 2024
4f874cc
Update epaule_semi_auto and epaule_a_un_coup base category
thomashbrnrd May 13, 2024
545ad01
Display MissingCardAlert only if gun is not dummy
thomashbrnrd May 13, 2024
aad43ac
Adapt low confidence screen to new design
thomashbrnrd May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions frontend/src/components/ContactExpert.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,4 @@ function onClose () {
margin: auto !important;
}

.w-100 {
width: 100% !important;
}

</style>
36 changes: 3 additions & 33 deletions frontend/src/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
html {
--select-option-image-width: 13rem;
}

h1 {
font-size: 1.75rem
}
Expand Down Expand Up @@ -35,18 +31,6 @@ a {
width: 100%;
}

.footer-up {
top: 97%;
}

button {
white-space: nowrap;
display: inline-flex;
width: fit-content;
align-items: center;
gap: 0.5rem;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure removing this piece of code does not have any influence anywhere in the display of all buttons in the app ?

.footer-text {
padding: 10px;
text-align: center;
Expand All @@ -71,22 +55,6 @@ button {
z-index: 1
}

.action-group {
text-align: center;
cursor: pointer;
margin: 8px 0;
}

.action-group:hover {
color: #1212ff;
}

.action-group-text {
font-size: 14px;
font-weight: bold;
margin: 0
}

.img-deco {
margin-bottom: 2.5em;
width: 100%
Expand All @@ -107,4 +75,6 @@ h5 {
background-image: var(--underline-img), var(--underline-img) !important;
}


.w-100 {
width: 100% !important;
}
4 changes: 0 additions & 4 deletions frontend/src/views/GuideContactExpert/ExpertSituation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,4 @@ function buildMailto (email: string) {
background-color: #E3E3FD;
}

.w-100 {
width: 100% !important;
}

</style>
4 changes: 0 additions & 4 deletions frontend/src/views/GuideIdentificationFirearm/IdentificationBlankGun.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,4 @@ const alarmGunsOptions = alarmGuns.options.filter(gun => gun.typology === result
max-width: 95%;
}

.w-100 {
width: 100%;
}

</style>
16 changes: 3 additions & 13 deletions frontend/src/views/GuideSecuringFirearm/SecuringTutorialContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,25 +259,15 @@ const openNextAccordion = (currentIndex: number) => {
</template>

<style scoped>
.img-deco {
margin-bottom: 1em;
margin-top: 0;
width: 75%;
}

.warning {
color : var(--red-marianne-425-625)
}

:deep(.fr-icon-home-3-line) {
color: var(--blue-france-sun-113-625);
}
.footer {
background-color: #fff;
box-shadow: 0 -4px 16px rgb(0 0 0 / 25%);
background-color: #fff;
box-shadow: 0 -4px 16px rgb(0 0 0 / 25%);
}
.footer button {
width: 50%;
width: 50%;
}

:deep(.fr-container) {
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/views/InstructionsPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function onFileSelected (event: InputEvent & { target: InputEvent['target'] & {
<div class="footer">
<div
v-if="!loading"
class="btn-read-instruction text-center"
class="text-center"
>
<div
class="fr-col-11 fr-col-lg-6 mx-auto"
Expand All @@ -140,7 +140,7 @@ function onFileSelected (event: InputEvent & { target: InputEvent['target'] & {
@change="onFileSelected($event)"
>
<DsfrButton
class="flex justify-center"
class="flex justify-center w-100"
data-testid="take-a-picture"
label="Prendre la photo"
icon="ri-camera-fill"
Expand All @@ -151,7 +151,7 @@ function onFileSelected (event: InputEvent & { target: InputEvent['target'] & {
</div>
<div
v-else
class="text-center bold"
class="text-center"
>
<p class="loading font-bold">
Analyse en cours
Expand Down
Loading