Add feedback when card is missing #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leihuayi
suggested changes
May 7, 2024
There was a problem hiding this comment.
- the name of the branch has no relationship whatsoever with what it actually does
- this work should be placed along with the global refactoring planned with @nutfdt
Please rename this branch and do the complete refactoring work in it.
| width: fit-content; | ||
| align-items: center; | ||
| gap: 0.5rem; | ||
| } |
There was a problem hiding this comment.
are you sure removing this piece of code does not have any influence anywhere in the display of all buttons in the app ?
thomashbrnrd
changed the title
thomashbrnrd
changed the title
thomashbrnrd
force-pushed
the
427-add-feedback-when-the-card-is-missing
branch
from
6a03d52 to
f7835c6
Compare
8 tasks
thomashbrnrd
force-pushed
the
427-add-feedback-when-the-card-is-missing
branch
from
f7835c6 to
bbc0486
Compare
thomashbrnrd
force-pushed
the
427-add-feedback-when-the-card-is-missing
branch
from
bbc0486 to
81633ef
Compare
leihuayi
approved these changes
May 13, 2024
leihuayi
suggested changes
May 13, 2024
| <img | ||
| class="px-2" | ||
| src="@/assets/guide-identification/icones/gun.jpg" | ||
| alt="" |
There was a problem hiding this comment.
Update this design when confidence level is low
leihuayi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.