-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch cycle - 2024 / Cycle 5 #186
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
68f9c48
Remove `.tool-versions`
dallasread 4978e72
Add support for JDK 23
dallasread db93986
Drop support for JDK 17
dallasread f6180db
Bump copyrights
dallasread e01749f
Deprecated collaborators
dallasread 3187231
Remove mention to ASDF
dallasread bc34c52
Update README
dallasread a24b39a
Update CONTRIBUTING.md
dallasread 06d93c0
Update CONTRIBUTING.md
dallasread File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ build | |
.gradle | ||
gradle.properties | ||
.DS_Store | ||
.tool-versions | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,7 +94,9 @@ public EmptyResponse deleteDomain(Number account, String domain) { | |
* @param domain The domain ID or name | ||
* @return The list collaborators response | ||
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#list">https://developer.dnsimple.com/v2/domains/collaborators/#list</a> | ||
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature. | ||
*/ | ||
@Deprecated(since = "2.0.0", forRemoval = true) | ||
public PaginatedResponse<Collaborator> listCollaborators(Number account, String domain) { | ||
return client.page(GET, account + "/domains/" + domain + "/collaborators", ListOptions.empty(), null, Collaborator.class); | ||
} | ||
|
@@ -107,7 +109,9 @@ public PaginatedResponse<Collaborator> listCollaborators(Number account, String | |
* @param options The options for the list request | ||
* @return The list collaborators response | ||
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#listCollaborators">https://developer.dnsimple.com/v2/domains/collaborators/#listCollaborators</a> | ||
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature. | ||
*/ | ||
@Deprecated(since = "2.0.0", forRemoval = true) | ||
public PaginatedResponse<Collaborator> listCollaborators(Number account, String domain, ListOptions options) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be a duplicate (we don't have an endpoint for account collaborators.) |
||
return client.page(GET, account + "/domains/" + domain + "/collaborators", options, null, Collaborator.class); | ||
} | ||
|
@@ -120,7 +124,9 @@ public PaginatedResponse<Collaborator> listCollaborators(Number account, String | |
* @param email The email of the collaborator | ||
* @return The add collaborator response | ||
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#addCollaborator">https://developer.dnsimple.com/v2/domains/collaborators/#addCollaborator</a> | ||
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature. | ||
*/ | ||
@Deprecated(since = "2.0.0", forRemoval = true) | ||
public SimpleResponse<Collaborator> addCollaborator(Number account, String domain, String email) { | ||
return client.simple(POST, account + "/domains/" + domain + "/collaborators", ListOptions.empty(), singletonMap("email", email), Collaborator.class); | ||
} | ||
|
@@ -133,7 +139,9 @@ public SimpleResponse<Collaborator> addCollaborator(Number account, String domai | |
* @param collaboratorId The collaborator ID | ||
* @return The remove collaborator response | ||
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#removeCollaborator">https://developer.dnsimple.com/v2/domains/collaborators/#removeCollaborator</a> | ||
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature. | ||
*/ | ||
@Deprecated(since = "2.0.0", forRemoval = true) | ||
public EmptyResponse removeCollaborator(Number account, String domain, String collaboratorId) { | ||
return client.empty(DELETE, account + "/domains/" + domain + "/collaborators/" + collaboratorId, ListOptions.empty(), null); | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢