Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch cycle - 2024 / Cycle 5 #186

Merged
merged 9 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
strategy:
matrix:
java-version:
- '17'
- '21'
- '23'
steps:
- uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java-version }}
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ build
.gradle
gradle.properties
.DS_Store
.tool-versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

1 change: 0 additions & 1 deletion .tool-versions

This file was deleted.

3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

- NEW: Added `alias_email` and `destination_email` to `EmailForward`
- CHANGED: Deprecated `from` and `to` fields in `EmailForward`
- CHANGE: Drop support for Java JDK 17
- CHANGE: Add support for Java JDK 23
- CHANGE: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.

## 1.0.0

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ cd dnsimple-java

### 2. Install external tools

The project includes an [ASDF](https://github.com/asdf-vm/asdf) `.tool-versions` file to set up the JVM required to work on the project.
- Eclipse Temurin JDK 21.0.5+11-:TS

You can install the required version of Java executing `asdf install` at the project's root directory.
From [https://adoptium.net/es/temurin/releases/](https://adoptium.net/es/temurin/releases/)

### 3. Build and test

Expand Down
2 changes: 1 addition & 1 deletion LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2016-2022 DNSimple Corporation
Copyright (c) 2016-2024 DNSimple Corporation

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ A Java client for the [DNSimple API v2](https://developer.dnsimple.com/v2/).

## Requirements

This library is tested with Java 17 (Temurin 21) and built for Java 17 JVMs.
This library is tested with Java 21+ (Temurin 21) and built for Java 21+ JVMs.

You must also have an activated DNSimple account to access the DNSimple API.

Expand Down Expand Up @@ -122,4 +122,4 @@ When developing unit tests for your application, you should stub responses from

## License

Copyright (c) 2016-2022 DNSimple Corporation. This is Free Software distributed under the MIT license.
Copyright (c) 2016-2024 DNSimple Corporation. This is Free Software distributed under the MIT license.
8 changes: 8 additions & 0 deletions src/main/java/com/dnsimple/endpoints/Domains.java
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ public EmptyResponse deleteDomain(Number account, String domain) {
* @param domain The domain ID or name
* @return The list collaborators response
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#list">https://developer.dnsimple.com/v2/domains/collaborators/#list</a>
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.
*/
@Deprecated(since = "2.0.0", forRemoval = true)
public PaginatedResponse<Collaborator> listCollaborators(Number account, String domain) {
return client.page(GET, account + "/domains/" + domain + "/collaborators", ListOptions.empty(), null, Collaborator.class);
}
Expand All @@ -107,7 +109,9 @@ public PaginatedResponse<Collaborator> listCollaborators(Number account, String
* @param options The options for the list request
* @return The list collaborators response
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#listCollaborators">https://developer.dnsimple.com/v2/domains/collaborators/#listCollaborators</a>
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.
*/
@Deprecated(since = "2.0.0", forRemoval = true)
public PaginatedResponse<Collaborator> listCollaborators(Number account, String domain, ListOptions options) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a duplicate (we don't have an endpoint for account collaborators.)

return client.page(GET, account + "/domains/" + domain + "/collaborators", options, null, Collaborator.class);
}
Expand All @@ -120,7 +124,9 @@ public PaginatedResponse<Collaborator> listCollaborators(Number account, String
* @param email The email of the collaborator
* @return The add collaborator response
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#addCollaborator">https://developer.dnsimple.com/v2/domains/collaborators/#addCollaborator</a>
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.
*/
@Deprecated(since = "2.0.0", forRemoval = true)
public SimpleResponse<Collaborator> addCollaborator(Number account, String domain, String email) {
return client.simple(POST, account + "/domains/" + domain + "/collaborators", ListOptions.empty(), singletonMap("email", email), Collaborator.class);
}
Expand All @@ -133,7 +139,9 @@ public SimpleResponse<Collaborator> addCollaborator(Number account, String domai
* @param collaboratorId The collaborator ID
* @return The remove collaborator response
* @see <a href="https://developer.dnsimple.com/v2/domains/collaborators/#removeCollaborator">https://developer.dnsimple.com/v2/domains/collaborators/#removeCollaborator</a>
* @deprecated `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.
*/
@Deprecated(since = "2.0.0", forRemoval = true)
public EmptyResponse removeCollaborator(Number account, String domain, String collaboratorId) {
return client.empty(DELETE, account + "/domains/" + domain + "/collaborators/" + collaboratorId, ListOptions.empty(), null);
}
Expand Down
Loading