Patch cycle - 2024 / Cycle 5 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dallasread
commented
Dec 9, 2024
| */ | ||
| @Deprecated(since = "2.0.0", forRemoval = true) | ||
| public PaginatedResponse<Collaborator> listCollaborators(Number account, String domain, ListOptions options) { |
There was a problem hiding this comment.
This seems to be a duplicate (we don't have an endpoint for account collaborators.)
ggalmazor
reviewed
Dec 11, 2024
| @@ -2,3 +2,4 @@ build | |||
| .gradle | |||
| gradle.properties | |||
| .DS_Store | |||
| .tool-versions | |||
ggalmazor
reviewed
Dec 11, 2024
ggalmazor
reviewed
Dec 11, 2024
ggalmazor
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks, @dallasread! I added a couple of suggestions in the docs to match the JDK we've been using lately
Co-authored-by: Guillermo Gutiérrez <[email protected]>
Co-authored-by: Guillermo Gutiérrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to go out in the next version (2.0.0) are:
alias_emailanddestination_emailtoEmailForwardfromandtofields inEmailForwardDomainCollaboratorshave been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.Belongs to https://github.com/dnsimple/dnsimple-engineering/issues/231