Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization support #3

Open
Denisov21 opened this issue Jul 5, 2014 · 22 comments
Open

Localization support #3

Denisov21 opened this issue Jul 5, 2014 · 22 comments

Comments

@Denisov21
Copy link
Contributor

No description provided.

@dnbard
Copy link
Owner

dnbard commented Jul 5, 2014

Do you want to help localize this extension to some specific language ?

@Denisov21
Copy link
Contributor Author

Hi, @dnbard Yes I can localize in Italian language!

@dnbard dnbard changed the title Add multilanguage! Localization support Jul 6, 2014
dnbard added a commit that referenced this issue Jul 6, 2014
dnbard added a commit that referenced this issue Jul 6, 2014
@dnbard
Copy link
Owner

dnbard commented Jul 6, 2014

@Denisov21 , please look at localization infrastructure that I've added recently. You can use default dictionary as example to create Italian localization.

@Denisov21
Copy link
Contributor Author

@dnbard
How do you know this method to translate extensions? I knew that there was only this: https://github.com/adobe/brackets/tree/master/src/extensions/samples/LocalizationExample

@dnbard
Copy link
Owner

dnbard commented Jul 7, 2014

@Denisov21 I've used something similar for much complex project at my work. Also I've used several third party libraries (like momentjs, message format etc) and MVVM framework (knockoutjs) along with it. Here is much lighter version of that solution.

@Denisov21
Copy link
Contributor Author

Close, thank you!

@Denisov21 Denisov21 reopened this Jul 7, 2014
@dnbard
Copy link
Owner

dnbard commented Jul 8, 2014

New localization strings added in db97927.
They will be displayed in default language (English) if they wont be included to appropriate dictionaries.

Note: more strings will be added before next release (v 0.3.0).
Note: I've marked the new strings with v 0.3.0 comment in English dictionary

@Denisov21
Copy link
Contributor Author

Sorry for all these PR I corrected an error loading the Italian language!

@dnbard
Copy link
Owner

dnbard commented Jul 19, 2014

New localization strings in 824f3c2 (Badges region of en-US.js)

@dnbard
Copy link
Owner

dnbard commented Jul 22, 2014

New localization strings in 9805b5f and e7d3cea (marked as v 0.4.0)

@iuliangcata
Copy link
Contributor

I want to contribute too, I can help you with es-ES (spanish), ca-ES (catalan), ro-RO (romanian). I have the files ready, but how about encodings ? How do you handle them in the js ? The part with the html tags I suppose uses the html codes and the variables, strings use escaping ?

@dnbard
Copy link
Owner

dnbard commented Jul 24, 2014

@enr00ted Hi.

I have the files ready, but how about encodings ? How do you handle them in the js ? 

Right now, I'm not handling encodings at all. I use what settings that Brackets setting to. I assume that it's an UTF-16.

The part with the html tags I suppose uses the html codes and the variables, strings use escaping ?

In <div>... and ${count} more versions</div> don't translate div and ${count}.

@dnbard
Copy link
Owner

dnbard commented Jul 24, 2014

Can I get permision for commit ?
Please do a pull request.

If you have questions about your commits, please provide link to them in your repository and we can continue discussion there.

@iuliangcata
Copy link
Contributor

I updated but still getting english by default in brackets.

@dnbard
Copy link
Owner

dnbard commented Jul 24, 2014

Please create new issue about this and we continue discussion there.

@dnbard
Copy link
Owner

dnbard commented Jul 30, 2014

I've added 2 more strings at 5d0ffd9 Please see changes in en-US.js file that are marked with v0.5.0 label

@dnbard
Copy link
Owner

dnbard commented Aug 3, 2014

I've added 1 new string in 206c982 . I feel that there may be more strings before v0.5.0 release.

@riteshbksc
Copy link

from last few days extension rating is not working. and had also stopped showing downloads of yesterday. the figure remains same each day.

@dnbard
Copy link
Owner

dnbard commented Aug 13, 2014

@riteshbksc Please create a separate issue for that. This is wrong topic to report bugs. Also this bug was on Brackets-registry side. It is already fixed, so we can only wait for that stats become available once again. Please refer to adobe/brackets#8402 if you need details.

@dnbard
Copy link
Owner

dnbard commented Sep 8, 2014

2 new strings for #84 in b7898ce

@riteshbksc
Copy link

Thanks for your valuable response.

I was just curious to know the about the way to know no. of users for a
particular extension simply. Not raising any bug for any extension and my
doubt has already been clarified.

Thanks a lot.

On Mon, Sep 8, 2014 at 12:44 PM, Alex Bardanov [email protected]
wrote:

2 new strings for #84
#84 in b7898ce
b7898ce


Reply to this email directly or view it on GitHub
#3 (comment)
.

http://www.refearn.com/[email protected]

@dnbard
Copy link
Owner

dnbard commented Oct 26, 2014

1 new string in ac8597c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants