tooltip for theme badge, fix #84

dnbard · Sep 8, 2014 · b7898ce · b7898ce
1 parent e36b211
commit b7898ce
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/extension/achievements/theme.js b/extension/achievements/theme.js
@@ -23,21 +23,23 @@ define(function(require, exports, module){
         }
 
         this.getTag = function(type, element){
-            var badge = null;
+            var badge = null, color;
 
             if (type === 'dark'){
-                //TODO: change to dark icon
                 badge = dark;
+                color = 'colorDark';
             } else if (type === 'light'){
-                //TODO: change to light icon
                 badge = light;
+                color = 'colorLight';
             } else {
                 badge = image;
+                color = '';
             }
 
-            return _.template('<span title="${title}" class="ext-badge ext-badge-theme"><img src="${badge}" /></span>',{
+            return _.template('<span title="${title}${color}" class="ext-badge ext-badge-theme"><img src="${badge}" /></span>',{
                 badge: badge,
-                title: locale.get('themeTitle')
+                title: locale.get('themeTitle'),
+                color: color ? '(' + locale.get(color) + ')' : ''
             });
         }
     }

diff --git a/extension/locale/en-US.js b/extension/locale/en-US.js
@@ -54,6 +54,10 @@ define(function (require, exports, module){
         versionTemplate: '<div>v ${version} from ${date} - ${downloads} downloads</div>',
 
         //... and ## more versions
-        moreVersionsTemplate: '<div>... and ${count} more versions</div>'
+        moreVersionsTemplate: '<div>... and ${count} more versions</div>',
+
+        //0.5.4
+        colorDark: 'dark',
+        colorLight: 'light'
     }
 });