Update x axis offset and update descriptions of ECAL BX binning plots #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejands
changed the title
|
Is this PR ready for merge and deployment in testbed? |
|
@muhammadimranfarooqi Yes this is ready to go |
|
I have deployed this in testbed. Please test and confirm it is ready for production deployment. Thanks |
|
Looks good. This is ready for production deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is complementary to CMSSW PRs cms-sw/cmssw#33264 (11_3_X) and cms-sw/cmssw#33275 (11_2_X backport).
Alongside changing the binning of the TP occupancy vs BX plot in CMSSW, we've made some minor updates to the ECAL DQM GUI code. These are an axis label offset for plots that are binned by BX and updating the descriptions of these plots to include minor details that may be useful for future reference.
We've validated the changes using a private Online DQM GUI and all the changes look good and ready to go for deployment.