-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change binning of TP occupnacy vs BX plot and edit BX plot descriptions #33275
Conversation
A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_11_2_X. It involves the following packages: DQM/EcalMonitorTasks @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56dae3/13794/summary.html Comparison SummarySummary:
|
I apologize for the delay but our DQM developer is on holidays these days and we would like to test this PR at DQM@P5 next week after Easter |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@alejands please note there is a comment here https://github.com/cms-sw/cmssw/pull/33264/files#r605397948 |
+1 |
PR description:
This PR is fulfilling a request from ECAL DAQ to change the binning in the TP occupancy vs BX plot to have finer BX bins. The new binning is by BX rather than by groups of BXs, similar to the Timing vs BX finely binned plot used in Offline DQM. This leads to the new plot to be quite busy with many bins, but the expectation is that DAQ experts will zoom in on the x-axis using the Customize button on the DQM GUI to study their region of interest.
Slight modifications were made to the TrigPrimTask module so the way the BX binning is done more closely matches what is done in the TimingTask module, which also contain some “vs BX” plots. Some plot descriptions were also updated to mention relevant information for these plots, such as the BX ids starting at 1, as well as a minor relabelling of the x-axis.
PR validation:
An Online DQM-like workflow was run and the plots were uploaded to a private DQM GUI. We verified with ECAL DAQ that the new binning was to their liking. We also verified that the new BX binning changes did not affect any other plot binned by BX.
Validations were rerun on the backport with no differences from the original PR.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of the following PR: #33264
The changes are wanted in CMSSW_11_2_X, to be used by DQM in the upcoming MWGR in April 2021.