Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra request parameter checks for [Non]CustodialSubType && AutoApproveSubscriptionSites. #11270

Conversation

todor-ivanov
Copy link
Contributor

@todor-ivanov todor-ivanov commented Sep 5, 2022

Fixes #11269

Status

ready

Description

With the current change we remove some extra parameters suggested by default and added to the table constructed in the Reqmgr Web interface for workflow status transition from assignment-approved to assigned. The list of removed fields is as follows:

AutoApproveSubscriptionSites
CustodialSubType
NonCustodialSubType

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Complement to #11181

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 3 changes in unstable tests
  • Python3 Pylint check: failed
    • 14 warnings and errors that must be fixed
    • 6 warnings
    • 236 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 113 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13569/artifact/artifacts/PullRequestReport.html

@todor-ivanov
Copy link
Contributor Author

Here are the results from the tests of the current PR: #11269 (comment)

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Todor, it looks good to me.

@amaltaro amaltaro merged commit ec7215b into dmwm:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken workflow status transition to assigned
3 participants