Dropping phedex args #11181
Merged
Dropping phedex args #11181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
96ed16c to
8aace28
Compare
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
8aace28 to
4cc7319
Compare
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
2 times, most recently
from
c629255 to
aeb77d4
Compare
|
Jenkins results:
|
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
aeb77d4 to
86a0925
Compare
|
Jenkins results:
|
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
86a0925 to
7e349c2
Compare
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
e93efeb to
f12b5f5
Compare
|
Jenkins results:
|
|
Jenkins results:
|
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
22801ea to
5773649
Compare
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
|
Hi @amaltaro , Alan seems that |
|
Jenkins results:
|
|
@jhonatanamado as we quickly discussed this morning, it turns out that we have already been running the oracle jenkins with this patch in. |
amaltaro
requested changes
Aug 29, 2022
There was a problem hiding this comment.
@jhonatanamado Jhonatan, these changes are looking great for me. I left a couple of comments along the code though.
In addition to that, could you please squash all these commits into only 2 commits:
- for src/* changes
- for test/* changes.
If you are unsure about this step, please let me know because we do not want to lose these changes ;)
|
@amaltaro , Thanks Alan. What about the modifications on the JSON templates, Should those be squashed with src/* changes? |
@jhonatanamado no, those changes go together with unit tests (2nd commit) |
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
737ac4d to
ebc324a
Compare
Dropping PhEDEx args_StdBase Dropping PhEDEx args_WMTask Dropping PhEDEx args_WMWorkload Dropping PhEDEx DAOs Dropping phedex MySQL_Create Dropping phedex MySQL_NewSubscription Dropping phedex Oracle_Create Dropping phedex Oracle_NewSubscription Dropping PhEDEx Rucio Component Dropping phedex UnsubscribedDts Dropping phedex RucioInjectorPoller Assign RUCIO_SUBSCRIPTION_PRIORITIES for containerRules Add RUCIO_RULES_PRIORITY Add dict to map PhEDEx priority to Rucio priority Change RUCIO_RULES_PRIORITY from Rucio to RucioUtils Add RUCIO_RULES_PRIORITY to RucioInjectorPoller Delete PhEDEx component Drop for loop from custodial Change to RUCIO_RULES_PRIORITY Dropping AutoApproveSubscriptionSites Delete auto_approve-AutoApproveSites NewSubscriptions Delete autoApproveSites from WMTask Deletete AutoApproval from WMWorkload Delete autoapprove from Oracle and create.py Delete autoapprove from RucioInjector-GetUnsubscr-Dtsets Delete validatePhEDExSubscription method
Dropping phedex StepChain Dropping phedex WMTask Dropping phedex WMWorkoad Dropping phedex WMBSHelper Delete PhEDEx component unit test Delete AutoApproval from unit-test Delete testValidatePhEDExSubscription from WMWorkload_t Updating ReqMgr json templates
jhonatanamado
force-pushed
the
dropping_PhEDEx_args
branch
from
ebc324a to
6c40002
Compare
|
Tests didn't come back - jenkins seem to be broken - but last unit tests were successful and the latest changes should have been safe enough. Merging it to get a new release out and deployed in testbed. |
This was referenced Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11145 and partially #9639 (Only T0 system)
Status
Tested with a replay
Description
Changes in several wfs arguments, some DAOs and RucioInjector to completely drop most of PhEDEx arguments in dataset subscriptions and use some of those arguments as an additional information for Rucio subscriptions
To wrap-up the following modifications are included in this PR:
move,phedex_groupCustodialSubType,NonCustodialSubType,CustodialGroup,NonCustodialGroupandAutoApproveSubscriptionSitesIs it backward compatible (if not, which system it affects?)
No. Database schema change with this dev
Related PRs
T0#4679
External dependencies / deployment changes
<Does it require deployment changes? Does it rely on third-party libraries?>
No