Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility fix #368

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Windows compatibility fix #368

merged 3 commits into from
Feb 17, 2022

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 17, 2022

Close #360

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #368 (7c57ecb) into mainline (60b732a) will decrease coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #368      +/-   ##
==============================================
- Coverage       84.82%   83.95%   -0.87%     
  Complexity         42       42              
==============================================
  Files             108      108              
  Lines            8664     8632      -32     
  Branches          510      510              
==============================================
- Hits             7349     7247     -102     
- Misses           1292     1362      +70     
  Partials           23       23              
Impacted Files Coverage Δ
include/treelite/predictor.h 72.09% <ø> (ø)
src/predictor/thread_pool/thread_pool.h 96.22% <ø> (ø)
python/treelite/contrib/msvc.py 0.00% <0.00%> (-67.15%) ⬇️
python/treelite/libpath.py 67.85% <0.00%> (-14.29%) ⬇️
runtime/python/treelite_runtime/libpath.py 67.85% <0.00%> (-14.29%) ⬇️
python/treelite/contrib/__init__.py 69.67% <0.00%> (-5.74%) ⬇️
python/treelite/contrib/util.py 86.17% <0.00%> (-4.26%) ⬇️
python/treelite/core.py 78.57% <0.00%> (-3.58%) ⬇️
runtime/python/treelite_runtime/util.py 92.10% <0.00%> (-2.64%) ⬇️
src/predictor/thread_pool/spsc_queue.h 93.75% <0.00%> (-2.09%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b732a...7c57ecb. Read the comment docs.

@hcho3 hcho3 mentioned this pull request Feb 17, 2022
@hcho3 hcho3 merged commit 9b416be into dmlc:mainline Feb 17, 2022
@hcho3 hcho3 deleted the fix_win branch February 17, 2022 21:50
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Feb 22, 2022
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #4590
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot built treelite4j.dll on Windows
1 participant