Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tree-parallel prediction in GTIL, if batch size is small #367

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Feb 17, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #367 (7647887) into mainline (e7fe6ee) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #367      +/-   ##
==============================================
+ Coverage       84.83%   84.92%   +0.08%     
  Complexity         42       42              
==============================================
  Files             108      108              
  Lines            8614     8654      +40     
  Branches          469      475       +6     
==============================================
+ Hits             7308     7349      +41     
+ Misses           1283     1282       -1     
  Partials           23       23              
Impacted Files Coverage Δ
src/gtil/predict.cc 91.94% <100.00%> (+1.24%) ⬆️
src/threading_utils/parallel_for.h 61.33% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7fe6ee...7647887. Read the comment docs.

Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hcho3 hcho3 merged commit b2a6a0a into dmlc:mainline Feb 17, 2022
@hcho3 hcho3 deleted the tree_parallel branch February 17, 2022 19:06
This was referenced Feb 17, 2022
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Feb 22, 2022
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #4590
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants