[BUGFIX] copy graph index to shared memory. #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -889,6 +914,9 @@ class ImmutableGraph: public GraphInterface { | |||
| if (!in_csr_) { | |||
| if (out_csr_) { | |||
| const_cast<ImmutableGraph*>(this)->in_csr_ = out_csr_->Transpose(); | |||
| if (out_csr_->IsSharedMem()) | |||
| LOG(WARNING) << "We just construct an in-CSR from a shared-memory out CSR. " | |||
| << "It may dramatically increase memory consumption."; | |||
There was a problem hiding this comment.
What does this mean? Is the in_csr also in shared memory? Is there any solution to this warning?
There was a problem hiding this comment.
I add this warning in case this happens. We could make sure the newly constructed csr is also in shared memory.
| @@ -318,7 +318,12 @@ class SharedMemoryStoreServer(object): | |||
| """ | |||
| def __init__(self, graph_data, edge_dir, graph_name, multigraph, num_workers, port): | |||
| self.server = None | |||
| if isinstance(graph_data, (GraphIndex, DGLGraph)): | |||
| if isinstance(graph_data, GraphIndex): | |||
| graph_data = graph_data.copyto_shared_mem(edge_dir, _get_graph_path(graph_name)) | |||
There was a problem hiding this comment.
We probably should make shared memory as a special device type (similar to kDLCPUPinned in current DLPack). I created a issue in DLPack (dmlc/dlpack#41) for this. This is definitely sth after this release though.
|
Could you briefly update the PR description about what is the bug? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If users provide a constructed graph index to SharedMemoryStoreServer, the graph index may not be in shared memory. We have to copy it to shared memory if it's not.
In addition, this PR gives shared memory for in-CSR and out-CSR different names. This is useful if a shared-memory graph index requires both in-CSR and out-CSR.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change