Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] enable tutorial test in CI. #631

Merged
merged 5 commits into from
Jun 13, 2019
Merged

Conversation

zheng-da
Copy link
Collaborator

@zheng-da zheng-da commented Jun 9, 2019

Description

Waiting for PR #634

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR

Changes

@jermainewang
Copy link
Member

BTW, could you try to simplify the MX tutorial so each runs under one minute?

@zheng-da
Copy link
Collaborator Author

i'm not sure how to do it. The sampling tutorial needs to run on a relatively large dataset. Otherwise, sampling makes no sense. I guess one possible way to create a sparsified Reddit ourselves and use that dataset instead.

@jermainewang
Copy link
Member

Smaller hidden size and fewer iteration? As long as the loss is dropping.

@zheng-da zheng-da merged commit be58224 into dmlc:master Jun 13, 2019
@zheng-da zheng-da deleted the fix_tutorial_test branch June 15, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants