Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add back the tox_loop implementation for low latency. #1

Open
wants to merge 75 commits into
base: master
Choose a base branch
from

Conversation

dmgolembiowski
Copy link
Owner

Copied code from TokTok#335.
Pulling this to peer review the efforts on tox-loop for sanity and safety

@iphydf iphydf force-pushed the tox-loop branch 3 times, most recently from 247d058 to dec479e Compare December 20, 2023 14:31
@iphydf iphydf force-pushed the tox-loop branch 2 times, most recently from a0ca575 to a3a9df6 Compare December 28, 2023 23:55
@iphydf iphydf force-pushed the tox-loop branch 2 times, most recently from 36aae48 to d0dec04 Compare January 17, 2024 22:51
@iphydf iphydf force-pushed the tox-loop branch 4 times, most recently from ec9309a to d47f9ca Compare January 27, 2024 00:02
@iphydf iphydf force-pushed the tox-loop branch 5 times, most recently from dd61134 to 38a0587 Compare February 2, 2024 23:52
@iphydf iphydf force-pushed the tox-loop branch 2 times, most recently from 40eccaf to b335fc2 Compare February 12, 2024 01:06
@iphydf iphydf force-pushed the tox-loop branch 2 times, most recently from 86f43fe to 489a7f5 Compare March 5, 2024 12:33
Green-Sky and others added 6 commits March 7, 2024 19:27
This only fixes the symptoms, not the real problem.
Sometimes or consistently on some platforms a socket might need a moment
before it can be written to.
In preparation for supporting `out` as a type qualifier in parameters.
Green-Sky and others added 29 commits November 8, 2024 21:11
- fix units to be more readable
- use width before height consistently
- video -> audio typo
Previously we unintentionally made it Mbit.
This was added everywhere except here.
Across PR milestone, "next" milestone, and draft release.
Bumps [third_party/cmp](https://github.com/TokTok/cmp) from `2ac6bca` to `52bfcfa`.
- [Commits](TokTok/cmp@2ac6bca...52bfcfa)

---
updated-dependencies:
- dependency-name: third_party/cmp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Allows clients to prevent leaking IP addresses through DNS lookups. This
option, together with disabling Tox UDP, entirely prevents any UDP
packets being sent by toxcore.
This is a band-aid solution that prevents friend requests with
long messages from being dropped. However it doesn't solve the
underlying problem, described here:
TokTok#2719
These warnings aren't available yet, but will be in a future
toktok-stack build.
In exchange, moved some github actions to circleci.
Significantly reduced the memory usage of groups since all message slots
are preallocated for every peer for send and receive buffers of buffer
size (hundreds of MiB peak when save contained alot of peers to try to
connect to)
This commit deprecates the tox_group_reconnect groupchat API function and
modifies the tox_group_join function to automatically reconnect to groups
when it's called with a chat_id that designates a group that it's already
a member of.

This allows clients to implement group rejoin functionality that lets peers
rejoin/reconnect to groups with a passed password argument, which may be
necessary if the group password changes while a peer is offline. This fixes
the bug described in TokTok#2806.
"tox error: 7" is less useful than "tox error:
TOX_ERR_FRIEND_CUSTOM_PACKET_SENDQ".
They are still experimental, but we can start integrating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants