forked from iphydf/c-toxcore
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add back the tox_loop
implementation for low latency.
#1
Open
dmgolembiowski
wants to merge
75
commits into
dmgolembiowski:master
Choose a base branch
from
iphydf:tox-loop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
tox-loop
branch
3 times, most recently
from
December 20, 2023 14:31
247d058
to
dec479e
Compare
iphydf
force-pushed
the
tox-loop
branch
2 times, most recently
from
December 28, 2023 23:55
a0ca575
to
a3a9df6
Compare
iphydf
force-pushed
the
tox-loop
branch
2 times, most recently
from
January 17, 2024 22:51
36aae48
to
d0dec04
Compare
iphydf
force-pushed
the
tox-loop
branch
4 times, most recently
from
January 27, 2024 00:02
ec9309a
to
d47f9ca
Compare
iphydf
force-pushed
the
tox-loop
branch
5 times, most recently
from
February 2, 2024 23:52
dd61134
to
38a0587
Compare
iphydf
force-pushed
the
tox-loop
branch
2 times, most recently
from
February 12, 2024 01:06
40eccaf
to
b335fc2
Compare
iphydf
force-pushed
the
tox-loop
branch
2 times, most recently
from
March 5, 2024 12:33
86f43fe
to
489a7f5
Compare
This only fixes the symptoms, not the real problem. Sometimes or consistently on some platforms a socket might need a moment before it can be written to.
In preparation for supporting `out` as a type qualifier in parameters.
- fix units to be more readable - use width before height consistently - video -> audio typo
Previously we unintentionally made it Mbit.
This was added everywhere except here.
Across PR milestone, "next" milestone, and draft release.
Bumps [third_party/cmp](https://github.com/TokTok/cmp) from `2ac6bca` to `52bfcfa`. - [Commits](TokTok/cmp@2ac6bca...52bfcfa) --- updated-dependencies: - dependency-name: third_party/cmp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Allows clients to prevent leaking IP addresses through DNS lookups. This option, together with disabling Tox UDP, entirely prevents any UDP packets being sent by toxcore.
This is a band-aid solution that prevents friend requests with long messages from being dropped. However it doesn't solve the underlying problem, described here: TokTok#2719
and make use of them
These warnings aren't available yet, but will be in a future toktok-stack build.
msan caught this.
In exchange, moved some github actions to circleci.
Significantly reduced the memory usage of groups since all message slots are preallocated for every peer for send and receive buffers of buffer size (hundreds of MiB peak when save contained alot of peers to try to connect to)
This commit deprecates the tox_group_reconnect groupchat API function and modifies the tox_group_join function to automatically reconnect to groups when it's called with a chat_id that designates a group that it's already a member of. This allows clients to implement group rejoin functionality that lets peers rejoin/reconnect to groups with a passed password argument, which may be necessary if the group password changes while a peer is offline. This fixes the bug described in TokTok#2806.
"tox error: 7" is less useful than "tox error: TOX_ERR_FRIEND_CUSTOM_PACKET_SENDQ".
They are still experimental, but we can start integrating.
Copied code from TokTok#335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied code from TokTok#335.
Pulling this to peer review the efforts on tox-loop for sanity and safety