-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tox_loop #335
Implement tox_loop #335
Conversation
c88b7ad
to
a279d20
Compare
Reviewed 8 of 9 files at r2. toxcore/Messenger.h, line 276 at r2 (raw file):
Change these to Messenger *m for consistency. toxcore/tox.c, line 477 at r2 (raw file):
toxcore/tox.c, line 489 at r2 (raw file):
I'm not sure if I like the idea of realloc() failing silently. It's fine for now, but it's very easy to mess up. toxcore/tox.c, line 503 at r2 (raw file):
Just a style suggestion: Put the 'if max_sockets == 0' clause in the loop condition. Comments from Reviewable |
Review status: 5 of 8 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed. toxcore/Messenger.h, line 276 at r2 (raw file): Previously, JFreegman wrote…
Done. toxcore/tox.c, line 477 at r2 (raw file): Previously, JFreegman wrote…
Done. toxcore/tox.c, line 489 at r2 (raw file): Previously, JFreegman wrote…
Done. toxcore/tox.c, line 503 at r2 (raw file): Previously, JFreegman wrote…
Done. Comments from Reviewable |
7da3044
to
7ea77ee
Compare
2da685c
to
5f57f4e
Compare
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
Copied code from TokTok#335.
As requested by @iphydf in #131 (comment)
Supersedes #131
CC: @JFreegman @iphydf @cleverca22
This change is