Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/453 introduced metrics etldplusone_total and etldplusone_top #465

Merged
merged 8 commits into from
Nov 21, 2023
Merged

issues/453 introduced metrics etldplusone_total and etldplusone_top #465

merged 8 commits into from
Nov 21, 2023

Conversation

kabenin
Copy link
Contributor

@kabenin kabenin commented Nov 13, 2023

This resolves #453

@dmachard
Copy link
Owner

Thank you for submitting this PR.
Please note that PR #456 (#456) needs to be merged before we can proceed with this one

@kabenin
Copy link
Contributor Author

kabenin commented Nov 17, 2023

Thanks, for the update, @dmachard!
I'm going to update prometheus logger and tests for it with the set of linters as proposed by #456, to make merge easier.

@kabenin
Copy link
Contributor Author

kabenin commented Nov 20, 2023

Hey @dmachard! I merged in the current master (after you've pushed #456). Tests look good.

@dmachard dmachard merged commit 2c0b1c5 into dmachard:main Nov 21, 2023
51 checks passed
@kabenin kabenin deleted the fix-for-453 branch November 21, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmachard dmachard dmachard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: extend Prometheus metrics by adding tld-plus-one statistics
2 participants
@kabenin @dmachard