Add more linters to golangci-lint #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlexis-tomtom
force-pushed
the
linting
branch
4 times, most recently
from
53fb02e to
8453b64
Compare
|
The gocritic commit contains actual code changes. I can recommend reviewing that commit properly. |
|
If you're OK with it, I'll review this PR as first for v0.39.0 |
|
No rush, just remember the conflicts will pile up :) |
|
Hi, the release v0.38.0 is out :) |
pieterlexis-tomtom
force-pushed
the
linting
branch
from
8453b64 to
6fb099c
Compare
Done, I hope I didn't mess things up :) |
pieterlexis-tomtom
force-pushed
the
linting
branch
from
6fb099c to
a07baa0
Compare
Some of the larger if statements have been marked with 'nolint' as they are correct and concise. This makes it hard to write the same functionality in a better way.
pieterlexis-tomtom
force-pushed
the
linting
branch
from
a07baa0 to
8d7d4bb
Compare
This comment is still relevant |
dmachard
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following linters and fixes the code for said linters: