Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: [redispub] reading redis responses #411

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

gallypette
Copy link
Contributor

fix #410

@dmachard
Copy link
Owner

Responses from redis are discarded, it's can not be useful to read it in some cases ?
Otherwise, LGTM.
Thanks again

@gallypette
Copy link
Contributor Author

The response in this case is the number of clients that consumed the message that was sent. It could be useful to some but I am more in a fire and forget situation regarding these messages.

@dmachard
Copy link
Owner

Ready to merge ?

@gallypette
Copy link
Contributor Author

I think so.
My test instance's memory seems sane with this patch so #353 could be considered fixed.

@adulau
Copy link

adulau commented Oct 13, 2023

We use it in production and it works as expected.

@dmachard
Copy link
Owner

Glad to hear that and thanks for your contributions.

Do you plan to share how the DNS-collector is used in your side ?
Usage in production may be useful for others :)

@dmachard dmachard merged commit 952ceb7 into dmachard:main Oct 13, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger: redispubsub - redis answers are not read.
3 participants