Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: redispubsub - redis answers are not read. #410

Closed
gallypette opened this issue Oct 6, 2023 · 5 comments · Fixed by #411
Closed

Logger: redispubsub - redis answers are not read. #410

gallypette opened this issue Oct 6, 2023 · 5 comments · Fixed by #411
Labels
bug Something isn't working

Comments

@gallypette
Copy link
Contributor

Oversight from me: redis returns an integer when one PUBLISH data on a pubsub channel (https://redis.io/commands/publish/).
So go-dnscollector process's Recv-Q grows until its limits, then redis process's Send-Q grows to its limit and then go-dnscollector hangs.

PR incoming.

@gallypette
Copy link
Contributor Author

BTW loggers/tcpclient.go suffers from the same issue.

@dmachard
Copy link
Owner

dmachard commented Oct 7, 2023

Thanks to catch that. it's can be also related to #353 ?
I will take a look to backport your fix to other loggers.

@dmachard dmachard added the bug Something isn't working label Oct 7, 2023
@gallypette
Copy link
Contributor Author

It should not be related to #353 as it clogs the OS TCP stack.
I am wondering if #353 is still an issue though, we started running a bigger collector over the week end and it is using around 320MB RSS with no ramping up in sight. I will know better as time passes.

@dmachard
Copy link
Owner

Thanks.
Any feedbacks regarding memory, cpu usage or performance will be really appreciated.

@gallypette
Copy link
Contributor Author

500MB after a day. I am unsure whether there is really an issue. I rewrote this part to remove allocations from the flush loop. This should already be better.
If that the case I will push the changes to this branch directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants