Inject source file (replaces #2207) #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 10, 2022 15:25
…al binaries (executed/shared libraries)
|
@WebFreak001 it has been 5 days, and you're aware of the previous PR so giving you a ping. |
|
|
|
will review in a minute, didn't really check github during easter holidays. |
WebFreak001
requested changes
Apr 19, 2022
Co-authored-by: Jan Jurzitza <[email protected]>
…to be more representative
WebFreak001
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #2207
Name changed to be injectSourceFiles.
Supports plural (and should also support globs, along with platform suffixes both haven't been tested as that is not a usecase).
Conversion between json/sdl has been tested.