-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injection of source files from dependencies into executable and shared libraries #2207
Conversation
…have source injected from dependencies.
…rceFile wasn't actually specified
…GitHub is complaining about
Currently missing is a test, dub describe for this property, changelog needs to cover the difference to sourceLibrary (@WebFreak001) and the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- no CI tests
- add difference (e.g. example) to targetType "sourceLibrary" to changelog pls
- the name seems a little unclear, what do others think here? (a better name would e.g. be like how you named your PR or the changelog entry with something like "injectSourceFile")
- can you make the new setting a list of files / globs? I think it would be easy to adjust and the current limit to a single file seems arbitrary given the other settings that exist.
- the new setting seems to behave a lot like
sourcePaths
, is there anything blocking this from having platform customizations? (I think TargetInfo should have what you need to support this)
The idea is a library/framework provides a single module that acts as an entry point to perform say registration. Everything can branch off of that. For that reason, this was modeled off of That is why I didn't support things like globs or multiple files per package. It isn't needed where it would be used, although it wouldn't be too hard to add if people really think it's required. I didn't add platform customizations as that seems kinda overkill. As its meant to be a single entry point that generally speaking won't care about the platform (if it does the compiler already gives you tons of information wrt. versions). |
…ly is fully recursive based upon for each executable and shared library targets
… cover comparison to sourceLibrary target type.
Current status: I need opinions about these three things. If people want name change/expanded feature set (it would not be impossible to add it later, just add a plural version of it, internally it could be easily changed).
This is going to be a lot more difficult to solve, |
I haven't tested conversion between sdl and json, so that'll need to be done too. |
This allows for libraries and frameworks to be able to hook into users code automatically without the user having to do anything special.
It has two use cases, although only one will work right now.
The first is my primary use case right now as I cannot find another way to solve this (while remaining automatic and stable).
The second use case is missing information about all modules that have been compiled into a shared library or executable. I do want to see this implemented because it does have the potential to be a game-changer in terms of UX for some libraries and frameworks.