Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FRONTEND, move dmd to latest by default. #2104

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Bump FRONTEND, move dmd to latest by default. #2104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d302e19
Update main.yml
maxhaton Feb 5, 2021
667d1c6
Update main.yml
maxhaton Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
matrix:
# Latest stable version, update at will
os: [ macOS-10.15, ubuntu-18.04, windows-2019 ]
dc: [ dmd-2.093.1, ldc-1.23.0, dmd-master, ldc-master ]
dc: [ dmd-latest, ldc-latest, dmd-master, ldc-master ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use a fixed release? #2105 is failing and I don't know if the problem is with my PR or because the test is now using a different compiler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose, but it fell several releases behind when it wasn't pegged to the latest release. Also dmd is tested upstream so hopefully the it should be on the PR not the compiler (in theory...)


runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
env:
COVERAGE: false
# The value doesn't matter as long as it's > 2.087
FRONTEND: 2.093.0
FRONTEND: 2.095.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those might get out of sync though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They did get out of sync - it seems to be an environment variable though, so I didn't see a simple way of doing it automatically at 5AM

run: |
dub build --compiler=${{ env.DC }}
dub run --compiler=${{ env.DC }} --single test/issue2051_running_unittests_from_dub_single_file_packages_fails.d
Expand Down