Bump FRONTEND, move dmd to latest by default. #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @maxhaton! |
Geod24
reviewed
Feb 5, 2021
| @@ -61,7 +61,7 @@ jobs: | |||
| env: | |||
| COVERAGE: false | |||
| # The value doesn't matter as long as it's > 2.087 | |||
| FRONTEND: 2.093.0 | |||
| FRONTEND: 2.095.0 | |||
There was a problem hiding this comment.
Those might get out of sync though
There was a problem hiding this comment.
They did get out of sync - it seems to be an environment variable though, so I didn't see a simple way of doing it automatically at 5AM
veelo
reviewed
Feb 9, 2021
| @@ -29,7 +29,7 @@ jobs: | |||
| matrix: | |||
| # Latest stable version, update at will | |||
| os: [ macOS-10.15, ubuntu-18.04, windows-2019 ] | |||
| dc: [ dmd-2.093.1, ldc-1.23.0, dmd-master, ldc-master ] | |||
| dc: [ dmd-latest, ldc-latest, dmd-master, ldc-master ] | |||
There was a problem hiding this comment.
Isn't it better to use a fixed release? #2105 is failing and I don't know if the problem is with my PR or because the test is now using a different compiler.
There was a problem hiding this comment.
I suppose, but it fell several releases behind when it wasn't pegged to the latest release. Also dmd is tested upstream so hopefully the it should be on the PR not the compiler (in theory...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.