Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow client param $port to be an integer or an array #160

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Allow client param $port to be an integer or an array #160

merged 1 commit into from
Apr 5, 2022

Conversation

nward
Copy link
Collaborator

@nward nward commented May 13, 2021

  • Add Array as an accepted type to freeradius::client
  • Add testing for the firewall rules defined in freeradius::client.

Fixes #136

@nward nward added this to the Version 4 milestone May 13, 2021
@nward nward requested a review from djjudas21 May 13, 2021 00:55
@nward nward force-pushed the 136-integer-data-type-too-restrictive-for-firewall-port branch from 5da59ea to 77e83c6 Compare May 13, 2021 01:00
djjudas21
djjudas21 previously approved these changes May 14, 2021
View reviewed changes
@nward nward force-pushed the 136-integer-data-type-too-restrictive-for-firewall-port branch from 77e83c6 to 9d298ce Compare May 14, 2021 10:30
@nward nward force-pushed the 136-integer-data-type-too-restrictive-for-firewall-port branch from 9d298ce to e3eb916 Compare May 25, 2021 11:46
@nward nward force-pushed the 136-integer-data-type-too-restrictive-for-firewall-port branch from e3eb916 to 88865f7 Compare October 14, 2021 23:08
@nward nward mentioned this pull request Apr 5, 2022
Closed
@nward nward merged commit 8411fd0 into djjudas21:main Apr 5, 2022
@nward nward mentioned this pull request Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djjudas21 djjudas21 djjudas21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 4
Development

Successfully merging this pull request may close these issues.

Integer data type too restrictive for firewall port
2 participants
@nward @djjudas21