Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer data type too restrictive for firewall port #136

Closed
decibelhertz opened this issue May 5, 2020 · 3 comments · Fixed by #160
Closed

Integer data type too restrictive for firewall port #136

decibelhertz opened this issue May 5, 2020 · 3 comments · Fixed by #160
Milestone

Comments

@decibelhertz
Copy link

https://github.com/djjudas21/puppet-freeradius/blob/master/manifests/client.pp#L19 requires an integer, but I would like to use the string '1812-1813 or array [1812,1813], which is valid for passing along to the firewall resource. Can you consider using Variant[Array[Integer],Integer]?

@djjudas21
Copy link
Owner

Thanks for this. Yes those ranges are valid for firewall rules and it's a good suggestion. Can you raise a PR, please?

@nward nward added this to the Version 4 milestone May 12, 2021
@nward
Copy link
Collaborator

nward commented May 12, 2021

Hi @decibelhertz I want to close this one off - are you OK if I raise the PR to fix this, or do you have one you can fire through?

@decibelhertz
Copy link
Author

decibelhertz commented May 12, 2021

Yes, please raise your own PR. I've been sidetracked on this matter and would be happy for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants