Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add django-cms 3.4 compatibility #62

Open
db654 opened this issue Sep 20, 2016 · 3 comments
Open

Add django-cms 3.4 compatibility #62

db654 opened this issue Sep 20, 2016 · 3 comments

Comments

@db654
Copy link

db654 commented Sep 20, 2016

Upgrading django-cms to 3.4 results in an import error due to reworking of the render_placeholder function. http://docs.django-cms.org/en/latest/upgrade/3.4.html#manual-plugin-rendering

File "/site/local/lib/python2.7/site-packages/cmsplugin_zinnia/admin.py", line 6, in
from cms.plugin_rendering import render_placeholder
ImportError: cannot import name render_placeholder
@bittner bittner mentioned this issue Nov 13, 2016
Open
bittner added a commit to bittner/cmsplugin-zinnia that referenced this issue Nov 14, 2016
@bittner
Make EntryPlaceholder work with django CMS 3.4
29bc6a6 
Fixes issues django-blog-zinnia#62 and django-blog-zinnia#63
@bittner bittner mentioned this issue Nov 14, 2016
Open
@bittner
Copy link
Contributor

bittner commented Nov 15, 2016

Django CMS 3.4 also introduces a backwards incompatible change to Apphooks.

PR #65 addresses this issue.

@fabidick22
Copy link

is this plugin still in development?

@swallace21
Copy link

Any updates on this plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@db654 @swallace21 @bittner @fabidick22