generated from distinction-dev/serverless-ts-plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/pe2 2277 unique role name #14
Open
joern-belonio
wants to merge
32
commits into
distinction-dev:main
Choose a base branch
from
belonio:fix/PE2-2277_unique_role_name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/pe2 2277 unique role name #14
joern-belonio
wants to merge
32
commits into
distinction-dev:main
from
belonio:fix/PE2-2277_unique_role_name
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex "^arn:(aws[a-zA-Z0-9-]*):([a-zA-Z0-9-]+):([a-z]{2}((-gov)|(-iso(b?)))?-[a-z]+-\\d{1})?:(\\d{12})?:(.+)$ has to use\\d{1} instead of d{1} or all arns like eu-central-1 are rejected as invalid.
fix(): Source ARN Regex
This reverts commit adf7f8b.
# 1.0.0 (2024-07-09) ### Bug Fixes * ♻️ Corrected the incorrect references for StartingPosition property in DynamoDB & kinesisStreams ([b7cd1e1](b7cd1e1)) * Source ARN Regex ([7a744d3](7a744d3)) ### Features * 🚧 Added some documentation exposing the api that will drive the config ([b5ca44f](b5ca44f)) * 📝 changed name of the package ([54514d1](54514d1))
fix(): Missing Step Function Action.
## [1.0.1](v1.0.0...v1.0.1) (2024-07-15) ### Bug Fixes * Missing Step Function Action. ([9e0e176](9e0e176))
…ssing fix(): SharedIAMRole Step Function was missing.
fix(): Shared Roles Testcase fixed
## [1.0.2](v1.0.1...v1.0.2) (2024-07-15) ### Bug Fixes * Shared Roles Testcase fixed ([01b013f](01b013f)) * SharedIAMRole Step Function was missing. ([1c7a907](1c7a907))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Pull-Request Checklist
main
branchyarn lint
passes with this changeyarn test
passes with this changeFixes #0000