Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Source ARN Regex #1

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

marco-belonio
Copy link

The regex

"^arn:(aws[a-zA-Z0-9-]*):([a-zA-Z0-9-]+):([a-z]{2}((-gov)|(-iso(b?)))?-[a-z]+-\d{1})?:(\d{12})?:(.+)$

has to use\d{1} instead of d{1} or all arns like eu-central-1 are rejected as invalid.

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • yarn lint passes with this change
  • yarn test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

The regex

"^arn:(aws[a-zA-Z0-9-]*):([a-zA-Z0-9-]+):([a-z]{2}((-gov)|(-iso(b?)))?-[a-z]+-\\d{1})?:(\\d{12})?:(.+)$

has to use\\d{1} instead of d{1} or all arns like eu-central-1 are rejected as invalid.
@marco-belonio marco-belonio merged commit 80bca93 into belonio:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants