Fix closing when thumbnail bounds are unknown #1563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when getThumbBoundsFn is false and the user closes the gallery, the zoom level and image position is reset. This causes a visible flash of the initial image if: * The image is zoomed in * The user drags down or pinches to close This changes the closing animation so that only the template is faded out, keeping the image in the correct place / zoom level.
arnowelzel
added a commit
to arnowelzel/PhotoSwipe
that referenced
this pull request
Sep 30, 2018
(As suggested in <dimsemenov#1563>)
|
Fixed by v5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
getThumbBoundsFnisfalseand the user closes the gallery, the zoom level and image position is reset. This causes a visible flash of the initial image if:This changes the closing animation so that only the template is faded out, keeping the image in the correct place / zoom level.