drag to close image to thumbnail

[osemec]

With showHideOpacity = true and getThumbBoundsFn = false, when I drag an image with mouse (up or down) to close it, the (full res) image jumped to center for a short time, before it closes.
(I'm using square thumbnails and full res images with different res.)

[arnowelzel]

I'm not sure, if this is what you're talking about - but I noticed that closing an image by dragging it upwards or downwards out of the view, it will not just be closed, but the whole image will show again and then fade out - which can be a bit irritating.

When dragging pictures up or down to close them, the whole fading stuff should not appear at all, since the picture is then already out sight.

[osemec]

Yes, this is the bug I was talking about.

[jefferyto]

Please give my PR #1563 a try - I believe it is a nicer-looking fix for this issue :-)

[arnowelzel]

I believe, PhotoSwipe 4 does not get any more updates here - the last commit is about 11 months ago and there are 60 open pull requests.

About your proposed fix: I'll try that on my own fork.

[arnowelzel]

Ok, looks nice. Now the picture does not just disappear but fade out properly. I will use this in my fork and for my WordPress plugin as well.

[arnowelzel]

JFTR: #1528

[jefferyto]

Thanks - I'm not expecting my pull request to be merged, just thought there may be other users who can benefit from it while waiting for the next version to be released.