Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture photo with Metadata #82

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Capture photo with Metadata #82

merged 3 commits into from
Dec 13, 2021

Conversation

dimonovdd
Copy link
Owner

@dimonovdd dimonovdd commented Dec 11, 2021 •
edited
Loading

Description

This Pull Request also fixes possible bugs related to video picking on iOS and #80

Related to issue

API Changes

Added:

public static bool CheckCapturePhotoSupport();

public static Task<IMediaFile> CapturePhotoAsync(CancellationToken token = default);

Recommendations for testing

Just capture photos

PR Checklist

  • All projects build
  • Has samples
  • Rebased onto current main

@dimonovdd dimonovdd changed the title Capture photos Capture photos with Metadata Dec 11, 2021
@dimonovdd dimonovdd added this to the 2.1.0 milestone Dec 11, 2021
@dimonovdd dimonovdd marked this pull request as draft December 11, 2021 22:36
@dimonovdd dimonovdd changed the title Capture photos with Metadata Capture photo with Metadata Dec 11, 2021
@dimonovdd dimonovdd marked this pull request as ready for review December 12, 2021 20:24
@dimonovdd dimonovdd merged commit b27483e into main Dec 13, 2021
@dimonovdd dimonovdd deleted the capturePhoto branch December 13, 2021 12:46
@dimonovdd dimonovdd mentioned this pull request Nov 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android CapturePhoto code improvement iOS PickMedia sampleProject Improvements or changes to Sample Project
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Capture Photo Incorrect behavior on Xiaomi and other androids
1 participant
@dimonovdd