Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop UseCreateChooser #134

Merged
merged 2 commits into from
Nov 4, 2024
Merged

drop UseCreateChooser #134

merged 2 commits into from
Nov 4, 2024

Conversation

dimonovdd
Copy link
Owner

Description

API Changes

UseCreateChooser property has been deleted. It is not used after merging #82

public class MediaPickRequest
{
    /// <summary>Gets or sets whether to use Intent.CreateChooser. Currently used only for Android.</summary>
    public bool UseCreateChooser { get; set; } = true;
}

#82

PR Checklist

  • All projects build
  • Has samples
  • Rebased onto current main

@dimonovdd dimonovdd requested a review from beeradmoore November 3, 2024 14:59
@dimonovdd dimonovdd self-assigned this Nov 3, 2024
Copy link
Collaborator

@beeradmoore beeradmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 instances of UseCreateChooser in README.md. We should remove them so people don't complain about code that doesn't work when they copy/paste examples

@dimonovdd dimonovdd force-pushed the maui-UseCreateChooser branch from 01d98ba to bc43aee Compare November 4, 2024 08:50
@dimonovdd
Copy link
Owner Author

@beeradmoore we will need to write documentation to migration for new version.

@dimonovdd dimonovdd merged commit 7936050 into main Nov 4, 2024
@dimonovdd dimonovdd deleted the maui-UseCreateChooser branch November 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants