Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only compiles
damlc-bootstrap
as a Haskell binary anddamlc
is a simple symlink with additional runfiles.To that end this PR adds a small Bazel rule
add_data
that symlinks a binary (copy on Windows) and extends its runfiles. Ideally, we could achieve the same usingsh_binary
, however due to bazelbuild/bazel#11820 this would break some targets usingdamlc
.We now need to define
damlc@ghci
manually since it is no longer defined automatically. The manual definition was tested withThe release tarball is not affected since
package_app
bundles the full binary.To be sure I have tested the resulting HEAD SDK on Windows and Linux by following the quickstart-java/quickstart test steps defined in the relase test guide.
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.