Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow space only device names #1014

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

cimigree
Copy link
Contributor

@cimigree cimigree commented Mar 3, 2025

Fixes #973
Makes sure need to enter some kind of text for device name by using trim()

The Edit Device Name did not need to be adjusted as it already does not allow just a blank space name.

@cimigree cimigree requested a review from achou11 March 3, 2025 21:59
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be a good case to cover via e2e tests, although maybe that's a follow-up since the current onboarding e2e test isn't ported yet?

@cimigree
Copy link
Contributor Author

cimigree commented Mar 3, 2025

would be a good case to cover via e2e tests, although maybe that's a follow-up since the current onboarding e2e test isn't ported yet?

@achou11 I can add it. I have that test ported. Want me to add it before I merge this in? You want to approve it?

@achou11
Copy link
Member

achou11 commented Mar 3, 2025

@achou11 I can add it. I have that test ported. Want me to add it before I merge this in? You want to approve it?

Ah great! No strong preference if done here or as a follow-up

@cimigree cimigree requested a review from achou11 March 3, 2025 23:57
@cimigree cimigree merged commit 5c1ae45 into develop Mar 4, 2025
7 checks passed
@cimigree cimigree deleted the fix/device-name-trim branch March 4, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device name can be set to just space characters
2 participants