fix: disallow space only device names (#1014)

* Makes sure need to enter some kind of text for device name * Adds a test to make sure white spaces for a device name error out
digidem · Mar 4, 2025 · 5c1ae45 · 5c1ae45
1 parent b2cf774
commit 5c1ae45
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/frontend/screens/Onboarding/DeviceNaming.tsx b/src/frontend/screens/Onboarding/DeviceNaming.tsx
@@ -36,7 +36,6 @@ export const DeviceNaming = ({
 }: NativeStackScreenProps<OnboardingParamsList, 'DeviceNaming'>) => {
   const [name, setName] = React.useState('');
   const [errorTimeout, setErrorTimeout] = useTemporaryError();
-  const invalidName = name.length === 0 || name.length > 60;
   const {formatMessage: t} = useIntl();
 
   function setNameWithValidation(nameValue: string) {
@@ -48,12 +47,13 @@ export const DeviceNaming = ({
   }
 
   function handleAddNamePress() {
-    if (invalidName) {
+    const trimmedName = name.trim();
+    if (trimmedName.length === 0 || trimmedName.length > 60) {
       setErrorTimeout();
       return;
     }
 
-    navigation.navigate('Success', {deviceName: name});
+    navigation.navigate('Success', {deviceName: trimmedName});
   }
   return (
     <KeyboardAvoidingView style={{width: '100%', height: '100%'}}>

diff --git a/tests/e2e/specs/onboarding/device-naming.test.ts b/tests/e2e/specs/onboarding/device-naming.test.ts
@@ -20,10 +20,19 @@ describe('Device Naming Test', () => {
 
     const successMessage = await $(byTextMatches('Success'));
     await driver.waitUntil(async () => !(await successMessage.isExisting()), {
-      timeout: 5000,
+      timeout: 2000,
       timeoutMsg: 'The success message did not appear within timeout',
     });
 
+    await deviceNameInput.setValue('    ');
+    await addNameButton.click();
+
+    await driver.waitUntil(async () => !(await successMessage.isExisting()), {
+      timeout: 2000,
+      timeoutMsg:
+        'Success message should not appear when input is only spaces.',
+    });
+
     await deviceNameInput.setValue(output.names.device);
     await addNameButton.click();