Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v0.8.0 ACA-Py spec #91

Merged
merged 137 commits into from
May 26, 2023
Merged

Upgrade to v0.8.0 ACA-Py spec #91

merged 137 commits into from
May 26, 2023

Conversation

lohanspies
Copy link
Collaborator

Upgrade aries-cloudcontroller v0.8.0 to match with Acapy v0.8.0.

@morrieinmaas, a few things regarding the generated models need to be clarified.
Some of the generated model code needs to be clarified, will need to verify what to include from the newly generated files and what to revert to the initially generated models.

@morrieinmaas
Copy link
Collaborator

@lohanspies looks mostly good. So thanks for doing the work. Bit unfortunate that you set the package version in setup.py to 0.8.0 (which is now released on at least test.pypi since i didn;t spot that - my bad bad). Let's make a release with this after double checking the models/what needs to be patched/whether sth needs to be patched as I'm not sure. Haven't touched this in a little while.

@morrieinmaas
Copy link
Collaborator

actually let's release this as candidate and see what breaks/whether anything breaks and add potential fixes in actual release or re-release as is if it's all good.

@lohanspies
Copy link
Collaborator Author

Cool. Thank @morrieinmaas.

Will check it out and potentially delete the packages from pypi and re-release to try and keep the controller version in sync with acapy.

Will focus on the cloudapi and will shout if encounter any issues

@ff137
Copy link
Collaborator

ff137 commented May 25, 2023

Changes confirmed in didx-xyz/aries-cloudapi-python#320

Summary:

  • models updated
  • the following required fields were reverted to optional, to solve unprocessable responses:
    • recipient_keys and service_endpoint in ServiceDecorator
  • reverted Union[RevRegResult, TxnOrRevRegResult] response for publish_rev_reg_def. Despite spec saying it's only TxnOrRevRegResult, it can respond with both
  • all def __init__ methods were removed for models, as it is already handled by Pydantic BaseModel, and it was causing naming conflicts when trying to parse aliased names.
  • validated that aliased name parsing works by adding more complex tests.

🎉 Ready to ship

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.9% 11.9% Duplication

@lohanspies lohanspies merged commit 0e8c2b9 into main May 26, 2023
@ff137
Copy link
Collaborator

ff137 commented May 26, 2023

Created issue on openwallet-foundation/acapy#2242 regarding empty fields in ServiceDecorator.

@ff137 ff137 deleted the chore/update-080-acapy branch July 14, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants