Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplink warnings for decorator for Python version >= 3.8 #63

Closed
morrieinmaas opened this issue Sep 8, 2021 · 3 comments
Closed

Uplink warnings for decorator for Python version >= 3.8 #63

morrieinmaas opened this issue Sep 8, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@morrieinmaas
Copy link
Collaborator

Currently using python3.8 causes the following warnings (when running the tests via pytest):

site-packages/uplink/clients/io/asyncio_strategy.py:26: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

There is a related issue in uplink opne issue that has some issues with using uplink with python3.8. This is another issue.

We should keep an eye on thsi as it will likely cause problems in the future.
@morrieinmaas morrieinmaas added the enhancement New feature or request label Sep 8, 2021
@TimoGlastra
Copy link
Collaborator

Is this fixed? I think it's still present right?

@morrieinmaas
Copy link
Collaborator Author

Yeah, maybe got a little too trigger happy tidying up. Will re-open

@morrieinmaas morrieinmaas reopened this Feb 25, 2022
@ff137
Copy link
Collaborator

ff137 commented May 26, 2023

Solved in #91 🎉

@ff137 ff137 closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morrieinmaas @TimoGlastra @ff137