[RAC][RBAC] - Addition of RBAC to tgrid #7

yctercero · 2021-06-09T08:08:34Z

… move to new rac tgrid work

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how
they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

WIP - trying to fix integration tests, broken authz for observer user / role updates authz feature builder to what ying had before we messed it up in our branch fixes integration tests add rac api access to apm adds getIndex functionality which requires the asset name to be passed in, same style as in the rule registry data client, adds update integration tests fix small merge conflict and update shell script fix merge conflict in alerting test file fix most type errors fix the rest of the type failures fix integration tests fix integration tests fix type error with feature registration in apm fix integration tests in apm and security solution fix type checker fix jest tests for apm remove console.error statements for eslint fix type check

…ture to 'read', utilizes the 'rule' object available in executor params over querying for the rule SO directly

… move to new rac tgrid work

yctercero · 2021-06-09T08:10:52Z

x-pack/plugins/rule_registry/common/mapping_from_field_map.ts

@@ -11,7 +11,7 @@ import { FieldMap } from './field_map/types';

 export function mappingFromFieldMap(fieldMap: FieldMap): TypeMapping {
  const mappings = {
-    dynamic: 'strict' as const,
+    dynamic: true,


Temporary workaround to unblock work, will not be merged. Seems to be newly introduced mapping issues related to the security solution rules that are being worked on.

yctercero · 2021-06-09T08:11:05Z

x-pack/plugins/rule_registry/server/event_log/log/utils/mapping_from_field_map.ts

@@ -11,7 +11,7 @@ import { IndexMappings } from '../../elasticsearch';

 export function mappingFromFieldMap(fieldMap: FieldMap): IndexMappings {
  const mappings = {
-    dynamic: 'strict' as const,
+    dynamic: true,


Temporary workaround to unblock work, will not be merged. Seems to be newly introduced mapping issues related to the security solution rules that are being worked on.

yctercero · 2021-06-09T08:11:35Z

x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_factory.ts

@@ -77,19 +77,21 @@ export const createPersistenceRuleTypeFactory: CreatePersistenceRuleTypeFactory
                const alertUuid = event['kibana.rac.alert.uuid'];
                const isAlert = alertUuid != null;
                return {
-                  ...event,
+                  // ...event,


Temporary workaround to unblock work, will not be merged. Seems to be newly introduced mapping issues related to the security solution rules that are being worked on.

yctercero · 2021-06-09T08:12:37Z

x-pack/plugins/security_solution/server/plugin.ts

@@ -237,7 +237,11 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
              settings: {
                number_of_shards: 1,
              },
-              mappings: {}, // TODO: Add mappings here via `mappingFromFieldMap()`
+              mappings: mappingFromFieldMap({


Temporary workaround to unblock work, will not be merged. Seems to be newly introduced mapping issues related to the security solution rules that are being worked on.

yctercero · 2021-06-09T08:13:05Z

x-pack/plugins/security_solution/server/plugin.ts

-          alerting: {
-            rule: {
-              all: ruleTypes,
+    if (experimentalFeatures.ruleRegistryEnabled) {


Adds the alerts updates subfeature UI if appropriate flag exists.

dhurley14

LGTM + and maybe a cypress test for ensuring we are getting back security solution alerts. This is awesome though well done!

dhurley14 and others added 13 commits June 7, 2021 07:02

update security solution jest tests

8f10a4d

cleaning up PR and adding basic unit tests

d1a252a

still need to clean up types in tests and update one test file

49f83b5

fixes snapshot for signals template

35b4a72

fix tests

098b744

fix type check failures

ee0f2cd

update cypress test

404e592

undo changes in alert authz class, updates alert privilege in apm fea…

9529d6d

…ture to 'read', utilizes the 'rule' object available in executor params over querying for the rule SO directly

remove verbose logging from detection api integration tests

78ec73c

fix type

0896f00

fix jest tests, adds missing mocked rule object to alert executor params

4d4920e

wip - addition of rbac to tgrid, based off of existing tgrid prior to…

c0872b5

… move to new rac tgrid work

yctercero commented Jun 9, 2021

View reviewed changes

did some cleanup

ecd8016

dhurley14 approved these changes Jun 9, 2021

View reviewed changes

yctercero added 2 commits June 9, 2021 09:20

added code sponsored by Lukas to expose internal search strategy

eb9d0e6

removed unnecessary change to type

b16e7c5

yctercero force-pushed the squashed_alerts_rbac_mvp_backup branch from c3008a8 to 7523f7e Compare June 14, 2021 20:21

dhurley14 force-pushed the squashed_alerts_rbac_mvp_backup branch 4 times, most recently from 9e19b5a to de863dc Compare June 21, 2021 17:53

yctercero force-pushed the squashed_alerts_rbac_mvp_backup branch from de863dc to b55aa7a Compare June 21, 2021 21:04

dhurley14 force-pushed the squashed_alerts_rbac_mvp_backup branch 2 times, most recently from 691c470 to 6111991 Compare June 22, 2021 23:47

yctercero force-pushed the squashed_alerts_rbac_mvp_backup branch from 039ba7a to ed094cd Compare June 30, 2021 15:40

dhurley14 force-pushed the squashed_alerts_rbac_mvp_backup branch from b1eebd6 to 634439b Compare July 1, 2021 22:16

yctercero force-pushed the squashed_alerts_rbac_mvp_backup branch from 634439b to fb1d9cc Compare July 5, 2021 19:03

dhurley14 force-pushed the squashed_alerts_rbac_mvp_backup branch 2 times, most recently from c22e179 to 220a8e9 Compare July 8, 2021 16:37

yctercero changed the base branch from squashed_alerts_rbac_mvp_backup to master July 8, 2021 21:31

yctercero closed this Oct 13, 2021

yctercero deleted the tgrid_rbac branch October 13, 2021 06:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAC][RBAC] - Addition of RBAC to tgrid #7

[RAC][RBAC] - Addition of RBAC to tgrid #7

yctercero commented Jun 9, 2021

yctercero Jun 9, 2021

yctercero Jun 9, 2021

yctercero Jun 9, 2021

yctercero Jun 9, 2021

yctercero Jun 9, 2021

dhurley14 left a comment

[RAC][RBAC] - Addition of RBAC to tgrid #7

[RAC][RBAC] - Addition of RBAC to tgrid #7

Conversation

yctercero commented Jun 9, 2021

Summary

Checklist

Risk Matrix

For maintainers

yctercero Jun 9, 2021

Choose a reason for hiding this comment

yctercero Jun 9, 2021

Choose a reason for hiding this comment

yctercero Jun 9, 2021

Choose a reason for hiding this comment

yctercero Jun 9, 2021

Choose a reason for hiding this comment

yctercero Jun 9, 2021

Choose a reason for hiding this comment

dhurley14 left a comment

Choose a reason for hiding this comment