-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Fix APM breadcrumbs on Serverless #191506
[APM] Fix APM breadcrumbs on Serverless #191506
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
b9701c1
to
f2dbcd2
Compare
/ci |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
[core.http.basePath, href, title] | ||
[core.http.basePath, href, title], | ||
{ | ||
omitOnServerless, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
], | ||
[pagePath, pageTitle, query, router, selectedTab, serviceGroupName, serviceGroupsLink], | ||
{ | ||
omitRootOnServerless: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Services
is automatically added on serverless
@@ -50,11 +49,13 @@ function serviceGroupPage<TPath extends string>({ | |||
return { | |||
[path]: { | |||
element: ( | |||
<Breadcrumb title={title} href={path}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
was removed to avoid conflicts with useBreadcrumb
in ServiceGroupTemplate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally off topic: never knew about these alert indicators. I'll immediately start (ab)-using these! :)
Other type of alerts per my recent findings:
Note
Highlights information that users should take into account, even when skimming.
Tip
Optional information to help a user be more successful.
Important
Crucial information necessary for users to succeed.
Warning
Critical content demanding immediate user attention due to potential risks.
Caution
Negative potential consequences of an action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say that I found that out a couple of days ago in one of @tonyghiani's PRs. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana.jsonc
changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obs-ux-management changes LGTM
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
fixes #8
fixes #7
Summary
Fixes APM breadcrumbs on serverless
How to test
Serverless
yarn es serverless --projectType=oblt --ssl -k/--insecure
yarn start --serverless=oblt --no-ssl
NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts --live --target=https://elastic_serverless:[email protected]:9200 --kibana=http://elastic_serverless:[email protected]:5601
NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts --live --target=https://elastic_serverless:[email protected]:9200 --kibana=http://elastic_serverless:[email protected]:5601
Stateful
node scripts/synthtrace mobile.ts --live
node scripts/synthtrace service_map.ts --live