Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API endpoints for Frequency Analysis #55

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

phuang00
Copy link
Contributor

This PR creates two API endpoints: all_frequency_analyses to get all of the existing frequency analyses and add_frequency_analysis to run an analysis based on the given corpus_id and gender_ids or it retrieves an existing entry from the FrequencyAnalysis model.

Note: We tried creating a FrequencyAnalysisManager and perform the run_analysis method in there but we ran into an issue of circular imports so we ultimately called the run_analysis method directly in the API endpoint.

farooqashar and others added 30 commits July 21, 2021 17:07
commit 427e51e
Merge: a267410 590b56e
Author: Peihua Huang <[email protected]>
Date:   Wed Jul 21 19:35:28 2021 -0400

    Merge pull request #46 from dhmit/create_single_corpus_component

    Create Single Corpus Component

commit 590b56e
Author: Peihua Huang <[email protected]>
Date:   Wed Jul 21 19:35:18 2021 -0400

    updated map function such that the data is first filtered then mapped

commit 2d88e42
Author: Peihua Huang <[email protected]>
Date:   Wed Jul 21 19:32:13 2021 -0400

    updated heading tags and loading states

commit 584c092
Merge: ddfa24d ead126f
Author: Peihua Huang <[email protected]>
Date:   Mon Jul 19 17:31:48 2021 -0400

    Merge branch 'main' into create_single_corpus_component

commit ddfa24d
Merge: f2fd0e1 e0d24bc
Author: Peihua Huang <[email protected]>
Date:   Mon Jul 19 17:22:06 2021 -0400

    Merge branch 'main' into create_single_corpus_component

commit f2fd0e1
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 16 17:03:50 2021 -0400

    italicized the title of documents and fixed linter warnings

commit 9e1e249
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 16 16:58:01 2021 -0400

    update corpus page to show list of documents in corpus and allows users to use a modal to update documents in the corpus

commit 057d88d
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 16 15:27:17 2021 -0400

    update API url and the way we check if a corpus contains a document

commit a8d3e18
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 15 16:32:18 2021 -0400

    update the way documents list is passed into api

commit f3dc588
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 15 16:07:09 2021 -0400

    update function naming typo

commit b474af5
Merge: 593547e 9b828d9
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 15 15:26:21 2021 -0400

    Merge branch 'main' into create_single_corpus_component

commit 593547e
Author: Peihua Huang <[email protected]>
Date:   Wed Jul 14 15:46:04 2021 -0400

    added list of documents that can be added to corpus

commit 2f2209a
Author: Peihua Huang <[email protected]>
Date:   Wed Jul 14 14:55:55 2021 -0400

    added path and get route to backend

commit 7eed0c0
Author: Peihua Huang <[email protected]>
Date:   Wed Jul 14 14:47:27 2021 -0400

    created corpus component
(and deleted all references to it in `Corpora.js`)
This creates the Proximity Analysis API endpoint and a way to see all the analyses
in `Corpora.js` and `Corpus.js`
Also resolved some linter/syntax errors
joshfeli and others added 9 commits July 23, 2021 16:01
commit 0fdfcc6
Merge: 1276da0 b10cfa9
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 15:48:02 2021 -0400

    Merge pull request #25 from dhmit/transfer_frequency_module_PR1

    Transfer frequency module pr1

commit 1276da0
Merge: 657b20f b5a9482
Author: YifanWang0 <[email protected]>
Date:   Fri Jul 23 15:38:12 2021 -0400

    Merge pull request #54 from dhmit/transfer_frequency_model

    Added FrequencyAnalysis model

commit b5a9482
Author: Yifan Wang <[email protected]>
Date:   Fri Jul 23 14:08:54 2021 -0400

    added FrequencyAnalysis model

commit b10cfa9
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:41:17 2021 -0400

    update run_analysis to use primary keys instead of labels and update result dictionary to key by gender object

commit 1196fc1
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:36:54 2021 -0400

    Revert "update frequency result to key by gender primary key instead of label"

    This reverts commit 151a4bc.

commit 151a4bc
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:34:11 2021 -0400

    update frequency result to key by gender primary key instead of label

commit 657b20f
Merge: 6619e68 3c6e5bf
Author: Joshua Feliciano <[email protected]>
Date:   Fri Jul 23 11:42:15 2021 -0400

    Merge pull request #52 from dhmit/remove_proximity_breakpoint

    Removed debugging breakpoint

commit 3c6e5bf
Author: Joshua Feliciano <[email protected]>
Date:   Thu Jul 22 17:50:15 2021 -0400

    Removed debugging breakpoint

commit 0684a02
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 16:43:50 2021 -0400

    got frequency analysis working with a corpus

commit 2003ce6
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 16:28:27 2021 -0400

    convert run_analysis to run_single_analysis, such that the function only takes in one document and update docstrings and added test

commit 0f817ba
Merge: dc21391 6619e68
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 14:54:15 2021 -0400

    Merge branch 'main' into transfer_frequency_module_PR1

commit dc21391
Author: Yifan Wang <[email protected]>
Date:   Wed Jul 7 16:44:55 2021 -0400

    fixed small mistakes according to pr comments

commit a852cd3
Author: Yifan Wang <[email protected]>
Date:   Mon Jun 28 16:42:28 2021 -0400

    added docstrings

commit 32731f4
Author: Yifan Wang <[email protected]>
Date:   Mon Jun 28 16:01:57 2021 -0400

    fixed minor bug with _run_analysis function

commit 233e2e6
Author: Yifan Wang <[email protected]>
Date:   Fri Jun 25 16:52:31 2021 -0400

    moved over run analysis but still need to fix bug with helper function
(not sure if this is needed)
Copy link

@sharabhuiyan sharabhuiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good to me! I was just confused by some logic in add_frequency_analysis().

backend/app/views.py Outdated Show resolved Hide resolved
backend/app/views.py Outdated Show resolved Hide resolved
Copy link

@sharabhuiyan sharabhuiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing things up and fixing the bug! Everything else in the PR looks good to me :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants