Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FrequencyAnalysis model #54

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Added FrequencyAnalysis model #54

merged 1 commit into from
Jul 23, 2021

Conversation

YifanWang0
Copy link
Contributor

This PR:

  • adds the FrequencyAnalysis model to memorize the results obtained by running the analysis functions
  • creates a serializer that serializes the model

Copy link
Contributor

@MBJean MBJean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Super straightforward, thanks!

@YifanWang0 YifanWang0 merged commit 1276da0 into main Jul 23, 2021
joshfeli added a commit that referenced this pull request Jul 23, 2021
commit 0fdfcc6
Merge: 1276da0 b10cfa9
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 15:48:02 2021 -0400

    Merge pull request #25 from dhmit/transfer_frequency_module_PR1

    Transfer frequency module pr1

commit 1276da0
Merge: 657b20f b5a9482
Author: YifanWang0 <[email protected]>
Date:   Fri Jul 23 15:38:12 2021 -0400

    Merge pull request #54 from dhmit/transfer_frequency_model

    Added FrequencyAnalysis model

commit b5a9482
Author: Yifan Wang <[email protected]>
Date:   Fri Jul 23 14:08:54 2021 -0400

    added FrequencyAnalysis model

commit b10cfa9
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:41:17 2021 -0400

    update run_analysis to use primary keys instead of labels and update result dictionary to key by gender object

commit 1196fc1
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:36:54 2021 -0400

    Revert "update frequency result to key by gender primary key instead of label"

    This reverts commit 151a4bc.

commit 151a4bc
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:34:11 2021 -0400

    update frequency result to key by gender primary key instead of label

commit 0684a02
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 16:43:50 2021 -0400

    got frequency analysis working with a corpus

commit 2003ce6
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 16:28:27 2021 -0400

    convert run_analysis to run_single_analysis, such that the function only takes in one document and update docstrings and added test

commit 0f817ba
Merge: dc21391 6619e68
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 14:54:15 2021 -0400

    Merge branch 'main' into transfer_frequency_module_PR1

commit dc21391
Author: Yifan Wang <[email protected]>
Date:   Wed Jul 7 16:44:55 2021 -0400

    fixed small mistakes according to pr comments

commit a852cd3
Author: Yifan Wang <[email protected]>
Date:   Mon Jun 28 16:42:28 2021 -0400

    added docstrings

commit 32731f4
Author: Yifan Wang <[email protected]>
Date:   Mon Jun 28 16:01:57 2021 -0400

    fixed minor bug with _run_analysis function

commit 233e2e6
Author: Yifan Wang <[email protected]>
Date:   Fri Jun 25 16:52:31 2021 -0400

    moved over run analysis but still need to fix bug with helper function
joshfeli added a commit that referenced this pull request Jul 23, 2021
commit 0fdfcc6
Merge: 1276da0 b10cfa9
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 15:48:02 2021 -0400

    Merge pull request #25 from dhmit/transfer_frequency_module_PR1

    Transfer frequency module pr1

commit 1276da0
Merge: 657b20f b5a9482
Author: YifanWang0 <[email protected]>
Date:   Fri Jul 23 15:38:12 2021 -0400

    Merge pull request #54 from dhmit/transfer_frequency_model

    Added FrequencyAnalysis model

commit b5a9482
Author: Yifan Wang <[email protected]>
Date:   Fri Jul 23 14:08:54 2021 -0400

    added FrequencyAnalysis model

commit b10cfa9
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:41:17 2021 -0400

    update run_analysis to use primary keys instead of labels and update result dictionary to key by gender object

commit 1196fc1
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:36:54 2021 -0400

    Revert "update frequency result to key by gender primary key instead of label"

    This reverts commit 151a4bc.

commit 151a4bc
Author: Peihua Huang <[email protected]>
Date:   Fri Jul 23 13:34:11 2021 -0400

    update frequency result to key by gender primary key instead of label

commit 657b20f
Merge: 6619e68 3c6e5bf
Author: Joshua Feliciano <[email protected]>
Date:   Fri Jul 23 11:42:15 2021 -0400

    Merge pull request #52 from dhmit/remove_proximity_breakpoint

    Removed debugging breakpoint

commit 3c6e5bf
Author: Joshua Feliciano <[email protected]>
Date:   Thu Jul 22 17:50:15 2021 -0400

    Removed debugging breakpoint

commit 0684a02
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 16:43:50 2021 -0400

    got frequency analysis working with a corpus

commit 2003ce6
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 16:28:27 2021 -0400

    convert run_analysis to run_single_analysis, such that the function only takes in one document and update docstrings and added test

commit 0f817ba
Merge: dc21391 6619e68
Author: Peihua Huang <[email protected]>
Date:   Thu Jul 22 14:54:15 2021 -0400

    Merge branch 'main' into transfer_frequency_module_PR1

commit dc21391
Author: Yifan Wang <[email protected]>
Date:   Wed Jul 7 16:44:55 2021 -0400

    fixed small mistakes according to pr comments

commit a852cd3
Author: Yifan Wang <[email protected]>
Date:   Mon Jun 28 16:42:28 2021 -0400

    added docstrings

commit 32731f4
Author: Yifan Wang <[email protected]>
Date:   Mon Jun 28 16:01:57 2021 -0400

    fixed minor bug with _run_analysis function

commit 233e2e6
Author: Yifan Wang <[email protected]>
Date:   Fri Jun 25 16:52:31 2021 -0400

    moved over run analysis but still need to fix bug with helper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants