-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crashing under ARMv6 #239
Conversation
goroutine 22 [running]:
runtime/internal/atomic.goLoad64(0x19b1744, 0x182bf9c, 0x3)
/usr/local/go/src/runtime/internal/atomic/atomic_arm.go:131 +0x1c
github.com/dgraph-io/ristretto.(*sampledLFU).getMaxCost(...)
/home/pi/neurons/vendor/github.com/dgraph-io/ristretto/policy.go:296
github.com/dgraph-io/ristretto.(*defaultPolicy).Add(0x19b1760, 0x3c60b443, 0x0, 0x38, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/pi/neurons/vendor/github.com/dgraph-io/ristretto/policy.go:140 +0x80
github.com/dgraph-io/ristretto.(*Cache).processItems(0x191fc80)
/home/pi/neurons/vendor/github.com/dgraph-io/ristretto/cache.go:435 +0x29c
created by github.com/dgraph-io/ristretto.NewCache
/home/pi/neurons/vendor/github.com/dgraph-io/ristretto/cache.go:204 +0x32c
|
rebase to latest head
@jarifibrahim @manishrjain can you review please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XIELongDragon apologies for the delay in review. Can you please add this comment https://github.com/dgraph-io/ristretto/pull/249/files#diff-2f3d176e1cb53549b532cb1313a54835140ac2ab5e3bbd6ea6b06f174ca5241dR282 ?
@jarifibrahim comments added |
ristretto will crash under ARM32. It is caused by the function
goLoad64
athttps://golang.org/src/runtime/internal/atomic/atomic_arm.go line 129
The root cause is the
sampledLFU
unalignedThis change is