Add pure read, write and read-write benchmarks #2
Conversation
|
|
mangalaman93
force-pushed
the
benchmark
branch
3 times, most recently
from
74d3de4 to
231a102
Compare
Comparing following libraries - * bigcache github.com/allegro/bigcache * freecache github.com/coocood/freecache * sync Map https://golang.org/pkg/sync/#Map The benchmarks are inspired from github repo github.com/ben-manes/caffeine and file caffeine/src/jmh/java/com/github/benmanes/caffeine/cache/GetPutBenchmark.java
mangalaman93
force-pushed
the
benchmark
branch
from
231a102 to
8f89f4a
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 4 unresolved discussions (waiting on @golangcibot and @manishrjain)
cache_bench_test.go, line 119 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
Error return value of
cache.Setis not checked (fromerrcheck)
Done
cache_bench_test.go, line 121 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
Error return value of
cache.Resetis not checked (fromerrcheck)
Done.
cache_bench_test.go, line 148 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
Error return value of
cache.Setis not checked (fromerrcheck)
Done.
cache_bench_test.go, line 199 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
Error return value of
cache.Setis not checked (fromerrcheck)
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 7 unresolved discussions (waiting on @golangcibot, @mangalaman93, and @manishrjain)
cache.go, line 2 at r1 (raw file):
/* * Copyright 2015-2018 Dgraph Labs, Inc. and Contributors
- The year that this code was written.
cache_bench_test.go, line 2 at r1 (raw file):
/* * Copyright 2015-2018 Dgraph Labs, Inc. and Contributors
2019 here and elsewhere.
cache_bench_test.go, line 63 at r1 (raw file):
// scrambled zipfian to ensure same keys are not together z := generator.NewScrambledZipfian(0, maxKey, generator.ZipfianConstant)
Why not rand.Zipf? It would avoid a dep on TiDB!
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 7 unresolved discussions (waiting on @golangcibot, @mangalaman93, and @manishrjain)
cache.go, line 2 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
- The year that this code was written.
Done.
cache_bench_test.go, line 2 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
2019 here and elsewhere.
Done.
cache_bench_test.go, line 63 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Why not rand.Zipf? It would avoid a dep on TiDB!
I thought about it. But I am not confident in using rand.Zipf. Two reasons -
- It takes two additional parameters s,v. I am not sure how they are used in order to generate the distribution and what their effect is on distribution
- Not confident that it won't cluster same keys together (whether it is scrambled)
I could probably figure this out, though, doesn't sound worth spending time on it. The random number generator that I am using is very similar to the one that Ben used.
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @golangcibot and @mangalaman93)
cache_bench_test.go, line 63 at r1 (raw file):
Previously, mangalaman93 (Aman Mangal) wrote…
I thought about it. But I am not confident in using rand.Zipf. Two reasons -
- It takes two additional parameters s,v. I am not sure how they are used in order to generate the distribution and what their effect is on distribution
- Not confident that it won't cluster same keys together (whether it is scrambled)
I could probably figure this out, though, doesn't sound worth spending time on it. The random number generator that I am using is very similar to the one that Ben used.
OK. We won't want to have the cache depend on TiDB. So, maybe it makes sense to put all these in a separate repository, as discussed today.
go.mod, line 1 at r2 (raw file):
module github.com/dgraph-io/caffeine
Let's not worry about all this for now, while we're still in flux about the deps. So, remove the go.mod and go.sum.
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @golangcibot and @mangalaman93)
Old PR: #1
Comparing following libraries -
The benchmarks are inspired from github repo
github.com/ben-manes/caffeine and file
caffeine/src/jmh/java/com/github/benmanes/caffeine/cache/GetPutBenchmark.java
This change is