Account for value size when restoring key/values from a backup. #1278
Conversation
The previous behavior only accouned for key size. For databases where keys are small (e.g., URLs) and values are much larger (megabytes), OOM errors were easy to trigger during restor operations. This change does not set the threshold use for flushing elegantly - a const is used instead of a configurable option. Related to dgraph-io#1268, but not a full fix.
gonzojive
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
|
|
|
Thank you for the PR @gonzojive. Please let me know once it is ready for review. |
|
I have a request in with my company for signing the CLA, but if it possible to skip signing the CLA, then we can proceed right away. |
|
@gonzojive Unfortunately, due to repository settings, I cannot merge any PRs without the CLA signed. |
|
Signed. I will let you know when cleaned up and ready for review. |
|
@gonzojive ping! Are you still working on this PR? I can take it from here if you aren't working on it :) |
|
I am not, please feel free to take over.
…On Tue, Apr 28, 2020 at 9:41 AM Ibrahim Jarif ***@***.***> wrote:
@gonzojive <https://github.com/gonzojive> ping! Are you still working on
this PR? I can take it from here if you aren't working on it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUO5ZL4NE7IGLJAYRH6NLRO4BKBANCNFSM4LUVDOPQ>
.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status/stale
lgalatin
removed
the
status/stale
|
Closing this PR in favor of #1358 . Thank you for the PR @gonzojive |
The previous behavior only accounted for key size. For databases where keys are
small (e.g., URLs) and values are much larger (megabytes), OOM errors were easy
to trigger during restore operations.
This change does not set the threshold used for flushing elegantly - a const is
used instead of a configurable option.
Related to #1268, but not a full fix.
This change is