Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add addUserHiddenDappId to canister methods #3856

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat(frontend): add addUserHiddenDappId to canister methods #3856

merged 3 commits into from
Dec 5, 2024

Conversation

AntonioVentilii
Copy link
Collaborator

Motivation

Thanks to PR #3777 , we add addUserHiddenDappId to the methods of class BackendCanister.

@AntonioVentilii AntonioVentilii requested a review from a team as a code owner December 4, 2024 20:34
DenysKarmazynDFINITY
DenysKarmazynDFINITY approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@DenysKarmazynDFINITY DenysKarmazynDFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, approving already.

Before merging, let's extend backend.canister.spec.ts with some basic test cases for the new method.

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) December 5, 2024 16:32
@AntonioVentilii AntonioVentilii merged commit 288b67e into main Dec 5, 2024
18 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(frontend)/add-addUserHiddenDappId-to-canister-methods branch December 5, 2024 16:36
@AntonioVentilii AntonioVentilii mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysKarmazynDFINITY DenysKarmazynDFINITY DenysKarmazynDFINITY approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii @DenysKarmazynDFINITY