feat(backend): function to add hidden dapps #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
approved these changes
Dec 4, 2024
| #[update(guard = "may_write_user_data")] | ||
| pub fn add_user_hidden_dapp_id( | ||
| request: AddHiddenDappIdRequest, | ||
| ) -> Result<(), AddDappSettingsError> { |
There was a problem hiding this comment.
Sounds like a good idea. :-) But doesn't have to be in this PR.
AntonioVentilii
deleted the
feat(backend)/function-to-add-hidden-dapps
branch
AntonioVentilii
added a commit
that referenced
this pull request
Dec 5, 2024
# Motivation Thanks to PR #3777 , we add `addUserHiddenDappId` to the methods of class `BackendCanister`.
AntonioVentilii
added a commit
that referenced
this pull request
Dec 6, 2024
# Motivation We add a close button to the carousel slides to hide them. # Note This affects only current navigation. Persisting that will be applied in another PR, using the backend method `add_hidden_dapp_id` introduced with PR #3777 # Changes - Add button close to component `DappsCarouselSlide`. - Bubble event `icCloseCarouselSlide` that provides the dApp that is being closed. - Create function in `DappsCarousel` to manage the event and remove the correspondent slide. - Adjust `Carousel` function removeSlide to refresh all needed variables. - Add transitions. # Tests https://github.com/user-attachments/assets/873fa742-5307-48a2-b81a-2276e54afdc7
This was referenced Dec 6, 2024
AntonioVentilii
added a commit
that referenced
this pull request
Dec 6, 2024
# Motivation We use the backend method `add_hidden_dapp_id` introduced with PR #3777 , to save the hidden slides/dApps in the backend. # Changes - Add event `oisyRefreshUserProfile` to refresh the user profile in `LoaderUserProfile`. It is useful to emit it when we know that we change the user profile. - Add method `add_hidden_dapp_id` in `DappCarousel` when closing a slide. # Tests https://github.com/user-attachments/assets/c849ed22-dfa3-4f51-90e8-5d6a446b5dfb --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to add an endpoint to add dApps that the user wants hidden in the dApps Carousel.
Changes
add_hidden_dapp_idtouser_profileimplementation.libTests
Included tests for new endpoint.